Skip to content

Convrting LUA keys and args to strings to comply with redis #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amotzg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Convrting LUA keys and args to strings to comply with redis #107

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddf0b5d
Convrting LUA keys and args to strings to comply with redis
Jul 2, 2015
390bbb4
Unit test for Lua arguments conversion to string.
amotzg Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mockredis/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __call__(self, keys=[], args=[], client=None):
if not client.script_exists(self.sha)[0]:
self.sha = client.script_load(self.script)

return self._execute_lua(keys, args, client)
return self._execute_lua([str(key) for key in keys], [str(arg) for arg in args], client)
Copy link
Contributor

@srikalyan srikalyan Jun 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some unit tests?

Copy link
Contributor Author

@amotzg amotzg Jun 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course.
I'll add it to test_script.py


def _execute_lua(self, keys, args, client):
"""
Expand Down