feat(website,docs): add options as a searchable dropdown to the metadata docs and use new template#6640
feat(website,docs): add options as a searchable dropdown to the metadata docs and use new template#6640anna-parker wants to merge 15 commits into
Conversation
|
Claude finished @anna-parker's task in 1m 16s —— View job Code Review
The implementation is clean and follows existing patterns. Two minor issues flagged as inline comments:
Testing: No automated tests were added for the new |
|
Claude finished @anna-parker's task in 1m 10s —— View job Code Review
The implementation is clean and well-scoped. Two issues flagged as inline comments:
Testing: No automated tests were added (noted in the PR checklist). For a docs UI component, manual verification via the preview URL is reasonable. If a test is added later, an interaction test checking that typing in the search box filters the list would be the most valuable scenario to cover. No security concerns — option names are rendered as text content, so no XSS risk. |
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…able.tsx Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
c4be671 to
b9bedc1
Compare
|
@claude review |
|
Claude finished @anna-parker's task in 1m 49s —— View job Code Review
Good iteration — the three issues from the previous rounds ( Bug: duplicate
|
| disabled={!isClient} | ||
| className='flex-1 border border-gray-300 rounded px-2 py-1 text-sm focus:outline-none focus:ring-1 focus:ring-primary-500 disabled:bg-gray-100' | ||
| /> | ||
| <Button |
There was a problem hiding this comment.
When I looked at the preview I really didn't know what this Copy button would do. I would have expected it to maybe copy what I put in the search box. I would maybe put it as a button styled as a small link under the box, then it also goes with the 2 of xx so it makes sense that it will only copy what's shown
There was a problem hiding this comment.
I will play around with this!
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0840f256b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </label> | ||
| <div className='flex gap-2'> | ||
| <input | ||
| id='allowed-values-search' |
There was a problem hiding this comment.
Generate a unique id for each options search input
This hard-coded id is rendered by every AllowedValuesList, so metadata pages with more than one controlled-vocabulary field produce duplicate DOM ids. In that scenario every Search available options label points at the first input instead of the list it belongs to, which breaks label focus behavior and makes the controls ambiguous for assistive tech; use a per-instance id (for example via useId or a field-specific prop).
Useful? React with 👍 / 👎.
…able.tsx Co-authored-by: Thomas Brier <46268349+tombch@users.noreply.github.com>
resolves #6639
Screenshot
Screen.Recording.2026-06-16.at.16.42.55.mov
PR Checklist
🚀 Preview: https://add-options-to-docs.loculus.org