cancel timer in destructor (#16)

bmagyar · web-flow · commit 3c0c8bab935a · 2025-11-14T10:45:32.000Z
diff --git a/orbbec_camera/src/ob_camera_node.cpp b/orbbec_camera/src/ob_camera_node.cpp
@@ -94,7 +94,12 @@ void OBCameraNode::setAndGetNodeParameter(
   }
 }
 
-OBCameraNode::~OBCameraNode() noexcept { clean(); }
+OBCameraNode::~OBCameraNode() noexcept {
+   if(diagnostic_timer_) {
+	   diagnostic_timer_->cancel();
+   }
+   clean();
+ }
 
 void OBCameraNode::rebootDevice() {
   RCLCPP_WARN_STREAM(logger_, "Reboot device");

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,12 @@ void OBCameraNode::setAndGetNodeParameter(`
`94`	`94`	`}`
`95`	`95`	`}`
`96`	`96`
`97`		`-OBCameraNode::~OBCameraNode() noexcept { clean(); }`
	`97`	`+OBCameraNode::~OBCameraNode() noexcept {`
	`98`	`+ if(diagnostic_timer_) {`
	`99`	`+ diagnostic_timer_->cancel();`
	`100`	`+ }`
	`101`	`+ clean();`
	`102`	`+ }`
`98`	`103`
`99`	`104`	`void OBCameraNode::rebootDevice() {`
`100`	`105`	`RCLCPP_WARN_STREAM(logger_, "Reboot device");`