Skip to content

Commit a9d2614

Browse files
committed
address review comments
1 parent 6fd43ff commit a9d2614

File tree

4 files changed

+62
-118
lines changed

4 files changed

+62
-118
lines changed

vcluster/learn-how-to/hardening-guide/README.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ apiVersion: v1
7474
kind: ConfigMap
7575
metadata:
7676
name: audit-config
77-
namespace: <vcluster-namespace>
77+
namespace: vcluster-my-vcluster
7878
data:
7979
audit-policy.yaml: |
8080
apiVersion: audit.k8s.io/v1
@@ -140,7 +140,7 @@ resources:
140140

141141
Create a secret in the vCluster namespace from the configuration file.
142142
```bash
143-
kubectl create secret generic encryption-config --from-file=encryption-config.yaml -n <vcluster-namespace>
143+
kubectl create secret generic encryption-config --from-file=encryption-config.yaml -n vcluster-my-vcluster
144144
```
145145

146146
Finally, create the vCluster referring the secret as:
@@ -180,7 +180,7 @@ apiVersion: v1
180180
kind: ConfigMap
181181
metadata:
182182
name: admission-control
183-
namespace: <vcluster-namespace>
183+
namespace: vcluster-my-vcluster
184184
data:
185185
admission-control.yaml: |
186186
apiVersion: apiserver.config.k8s.io/v1

vcluster/learn-how-to/hardening-guide/control-plane-components.mdx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ vcluster create my-vcluster -f vcluster.yaml --connect=false
392392

393393
Run the following command against the vCluster pod:
394394
```bash
395-
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -- ps -ef | grep kube-apiserver
395+
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -c syncer -- ps -ef | grep kube-apiserver
396396
```
397397
Verify that the --anonymous-auth argument is set to false.
398398

@@ -452,7 +452,7 @@ vcluster create my-vcluster -f vcluster.yaml --connect=false
452452

453453
Run the following command against the vCluster pod:
454454
```bash
455-
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -- ps -ef | grep kube-apiserver
455+
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -c syncer -- ps -ef | grep kube-apiserver
456456
```
457457
Verify that the `DenyServiceExternalIPs' argument exist as a string value in --enable-admission-plugins.
458458

@@ -525,7 +525,7 @@ vcluster create my-vcluster -f vcluster.yaml --connect=false
525525

526526
Run the following command against the vCluster pod:
527527
```bash
528-
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -- ps -ef | grep kube-apiserver
528+
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -c syncer -- ps -ef | grep kube-apiserver
529529
```
530530
Verify that the --authorization-mode argument exists and is set to a value to include Node.
531531

@@ -1216,7 +1216,7 @@ resources:
12161216
```
12171217
Create a secret in the vCluster namespace from the configuration file.
12181218
```bash
1219-
kubectl create secret generic encryption-config --from-file=encryption-config.yaml -n <vcluster-namespace>
1219+
kubectl create secret generic encryption-config --from-file=encryption-config.yaml -n vcluster-my-vcluster
12201220
```
12211221

12221222
Finally, create the vCluster referring the secret as:
@@ -1289,7 +1289,7 @@ resources:
12891289
```
12901290
Create a secret in the vCluster namespace from the configuration file.
12911291
```bash
1292-
kubectl create secret generic encryption-config --from-file=encryption-config.yaml -n <vcluster-namespace>
1292+
kubectl create secret generic encryption-config --from-file=encryption-config.yaml -n vcluster-my-vcluster
12931293
```
12941294

12951295
Finally, create the vCluster referring the secret as:

vcluster/learn-how-to/hardening-guide/control-plane.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ apiVersion: v1
4040
kind: ConfigMap
4141
metadata:
4242
name: audit-config
43-
namespace: <vcluster-namespace>
43+
namespace: vcluster-my-vcluster
4444
data:
4545
audit-policy.yaml: |
4646
apiVersion: audit.k8s.io/v1
@@ -69,15 +69,15 @@ controlPlane:
6969
mountPath: /etc/kubernetes
7070
```
7171
72+
**Audit:**
7273
Create the vCluster using the above values file.
7374
```bash
7475
vcluster create my-vcluster -f vcluster.yaml --connect=false
7576
```
7677

77-
**Audit:**
7878
Run the following command against the vCluster pod:
7979
```bash
80-
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -- ps -ef | grep kube-apiserver
80+
kubectl exec -n vcluster-my-vcluster my-vcluster-0 -c syncer -- ps -ef | grep kube-apiserver
8181
```
8282
Verify that the --audit-policy-file is set.
8383

@@ -107,7 +107,7 @@ apiVersion: v1
107107
kind: ConfigMap
108108
metadata:
109109
name: audit-config
110-
namespace: <vcluster-namespace>
110+
namespace: vcluster-my-vcluster
111111
data:
112112
audit-policy.yaml: |
113113
apiVersion: audit.k8s.io/v1

0 commit comments

Comments
 (0)