From 5d987bdd489e83f444b465aa6e10ea90453af46e Mon Sep 17 00:00:00 2001 From: cawamata <1749824+cawamata@users.noreply.github.com> Date: Thu, 10 Jun 2021 19:51:16 +0900 Subject: [PATCH 1/3] Update s3.rb signature_version supports s3, not v2 --- lib/logstash/outputs/s3.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/logstash/outputs/s3.rb b/lib/logstash/outputs/s3.rb index 3b51f633..697cfd79 100644 --- a/lib/logstash/outputs/s3.rb +++ b/lib/logstash/outputs/s3.rb @@ -164,7 +164,7 @@ class LogStash::Outputs::S3 < LogStash::Outputs::Base # The version of the S3 signature hash to use. Normally uses the internal client default, can be explicitly # specified here - config :signature_version, :validate => ['v2', 'v4'] + config :signature_version, :validate => ['s3', 'v4'] # Define tags to be appended to the file on the S3 bucket. # From 5dd311431b39d31f262641d04f8edb903ee49272 Mon Sep 17 00:00:00 2001 From: cawamata <1749824+cawamata@users.noreply.github.com> Date: Thu, 10 Jun 2021 19:52:23 +0900 Subject: [PATCH 2/3] Update index.asciidoc signature_version supports s3 --- docs/index.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.asciidoc b/docs/index.asciidoc index 6132ef2a..d9a005d0 100644 --- a/docs/index.asciidoc +++ b/docs/index.asciidoc @@ -103,7 +103,7 @@ This plugin supports the following configuration options plus the <> |<>|No | <> |<>, one of `["AES256", "aws:kms"]`|No | <> |<>|No -| <> |<>, one of `["v2", "v4"]`|No +| <> |<>, one of `["s3", "v4"]`|No | <> |<>|No | <> |<>|No | <> |<>, one of `["STANDARD", "REDUCED_REDUNDANCY", "STANDARD_IA", "ONEZONE_IA"]`|No From 0f436070e8219431383798943d5cfaa0a9faef09 Mon Sep 17 00:00:00 2001 From: cawamata <1749824+cawamata@users.noreply.github.com> Date: Thu, 10 Jun 2021 19:54:19 +0900 Subject: [PATCH 3/3] Update s3_spec.rb signature_version supports s3 --- spec/outputs/s3_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/outputs/s3_spec.rb b/spec/outputs/s3_spec.rb index 4de2ac91..e9a72f76 100644 --- a/spec/outputs/s3_spec.rb +++ b/spec/outputs/s3_spec.rb @@ -30,7 +30,7 @@ context "#register configuration validation" do describe "signature version" do it "should set the signature version if specified" do - ["v2", "v4"].each do |version| + ["s3", "v4"].each do |version| s3 = described_class.new(options.merge({ "signature_version" => version })) expect(s3.full_options).to include(:signature_version => version) end