Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use "list" as method name #24

Open
jeremiegrenier opened this issue Feb 14, 2022 · 1 comment
Open

Do not use "list" as method name #24

jeremiegrenier opened this issue Feb 14, 2022 · 1 comment

Comments

@jeremiegrenier
Copy link

jeremiegrenier commented Feb 14, 2022

All classes in the "API" namespace have a method named "list".

This causes an error lower to PHP5.6: Tag 3.0.0 is allowed to work with php5.6 but have "list"

PHP Parse error:  syntax error, unexpected 'list' (T_LIST), expecting '('

Because "list" is a keyword in PHP, it could not be used as a method name.

See Documentation

@TheLevti
Copy link
Contributor

TheLevti commented Nov 10, 2022

php 5.6 moved long ago to end of life. See: https://www.php.net/supported-versions.php. Please move on, there is no benefit to keep supporting such old versions, rather a slow down of progress.

If the maintainer is up for that, submit a pull request based on 3.1.0 to push a legacy release 3.x.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants