fix: allow sparse holes in btree validation invariants#96
Merged
Conversation
validate_tree and compio_erase asserted a dense-file model (blocks starting at 0, contiguous, covering the whole file). Writing past EOF legitimately creates sparse holes that compio_read zero-fills on demand and compio_erase collapses, so these debug-only asserts aborted Debug builds on valid file states. Relax the invariants: forbid only block overlap, allow leading/trailing and interior holes; drop the dense-coverage asserts in compio_erase since its range may be empty or partial inside a hole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_tree and compio_erase asserted a dense-file model (blocks
starting at 0, contiguous, covering the whole file). Writing past EOF
legitimately creates sparse holes that compio_read zero-fills on demand
and compio_erase collapses, so these debug-only asserts aborted Debug
builds on valid file states.
Relax the invariants: forbid only block overlap, allow leading/trailing
and interior holes; drop the dense-coverage asserts in compio_erase
since its range may be empty or partial inside a hole.