Addressed a few PR comments.

Author: Patrick Ingraham

python/lsst/ts/externalscripts/auxtel/latiss_take_flats.py

@@ -90,31 +90,31 @@ async def run(self, simulation_mode: int = 0):
     @classmethod
     def get_schema(cls):
         yaml_schema = """
-$schema: http://json-schema/draft-07/schema#
-$id: https://github.com/lsst-ts/ts_externalscripts/auxtel/LatissTakeFlats.yaml
-title: LatissTakeFlats v1
-description: Configuration for LatissTakeFlats.
-type: object
-properties:
-    latiss_filter:
-        type: string
-        default: 'empty_1'
-    latiss_grating:
-        type: string
-        default: 'empty_1'
-    sequence:
-        description: Yaml string with all required data.
-        anyOf:
-            - type: string
-            - type: "null"
-        default: null
-
-    s3instance:
-        type: string
-        default: 'cp'
-
-required: [latiss_filter, latiss_grating]
-additionalProperties: false
+            $schema: http://json-schema/draft-07/schema#
+            $id: https://github.com/lsst-ts/ts_externalscripts/auxtel/LatissTakeFlats.yaml
+            title: LatissTakeFlats v1
+            description: Configuration for LatissTakeFlats.
+            type: object
+            properties:
+                latiss_filter:
+                    type: string
+                    default: 'empty_1'
+                latiss_grating:
+                    type: string
+                    default: 'empty_1'
+                sequence:
+                    description: Yaml string with all required data.
+                    anyOf:
+                        - type: string
+                        - type: "null"
+                    default: null
+
+                s3instance:
+                    type: string
+                    default: 'cp'
+
+            required: [latiss_filter, latiss_grating]
+            additionalProperties: false
             """
         return yaml.safe_load(yaml_schema)
 
@@ -364,12 +364,6 @@ async def prepare_summary_table(self):
         Checks writing is possible and that s3 bucket can be made
         """
 
-        # file_output_dir = "/tmp/LatissTakeFlats/"
-        # write folder if required
-        # pathlib.Path().mkdir(parents=True, exist_ok=True)
-        # self.filename =
-        # f"LatissTakeFlats_sequence_summary_{self.group_id}.json"
-
         # Take a copy as the starting point for the summary
         self.sequence_summary = {}
 

python/lsst/ts/externalscripts/data/scripts/auxtel/latiss_take_flats.py

@@ -21,6 +21,6 @@
 
 import asyncio
 
-from lsst.ts.externalscripts.auxtel.build_pointing_model import BuildPointingModel
+from lsst.ts.externalscripts.auxtel.latiss_take_flats import LatissTakeFlats
 
-asyncio.run(BuildPointingModel.amain())
+asyncio.run(LatissTakeFlats.amain())

tests/auxtel/test_latiss_cwfs_align.py

@@ -64,7 +64,7 @@
     butler = dafButler.Butler(
         DATAPATH,
         instrument="LATISS",
-        collections=["LATISS/raw/all", "LATISS_test_data"],
+        collections=["LATISS/raw/all", "LATISS-test-data"],
     )
     DATA_AVAILABLE = True
 except FileNotFoundError:

tests/auxtel/test_latiss_take_flats.py

@@ -23,30 +23,21 @@
 import asyncio
 import logging
 import os
-import random
 import unittest
-import shutil
 import yaml
 
 import pytest
 from lsst.ts import externalscripts, standardscripts
 from lsst.ts.externalscripts.auxtel import LatissTakeFlats
 from lsst.utils import getPackageDir
 
-random.seed(47)  # for set_random_lsst_dds_partition_prefix
-
 logger = logging.getLogger(__name__)
 logger.propagate = True
 
 
 class TestLatissTakeFlats(
     standardscripts.BaseScriptTestCase, unittest.IsolatedAsyncioTestCase
 ):
-    def tearDown(self) -> None:
-        file_path = "/tmp/LatissTakeFlats/"
-        if os.path.isdir(file_path):
-            shutil.rmtree(file_path)
-
     def setUp(self) -> None:
         os.environ["LSST_SITE"] = "test"
         self.log = logging.getLogger(type(self).__name__)
@@ -171,27 +162,6 @@ async def test_configure(self):
                 latiss_grating=latiss_grating,
             )
 
-        async with self.make_script():
-            # Try more complex parameters
-            latiss_filter = "SDSSr_65mm"
-            latiss_grating = "empty_1"
-            # load a complex sequence defined as yaml
-            test_sequence_path = os.path.join(
-                getPackageDir("ts_externalscripts"),
-                "tests",
-                "data",
-                "auxtel",
-                "test_sequence1.yaml",
-            )
-            with open(test_sequence_path, "r") as file:
-                sequence = yaml.safe_load(file)
-
-            await self.configure_script(
-                latiss_filter=latiss_filter,
-                latiss_grating=latiss_grating,
-                sequence=sequence,
-            )
-
     async def test_invalid_sequence(self):
         # invalid filters, script should configure and hardware will get
         # setup but fail.
@@ -215,7 +185,6 @@ async def test_sequence(self):
         # valid sequence, using the default
 
         async with self.make_script():
-            # Try configure with invalid sequence data.
             latiss_filter = "SDSSr_65mm"
             latiss_grating = "empty_1"