Merge pull request #309 from lsst/tickets/DM-47544

DM-47544: Change calcSizeResidual from (T_obs-T_psf)/T_psf to (T_obs-T_psf)/T_obs

Author: arunkannawadi

python/lsst/analysis/tools/actions/vector/calcRhoStatistics.py

@@ -215,17 +215,17 @@ def __call__(self, data: KeyedData, **kwargs) -> KeyedData:
 
         calcSizeResidual = FractionalDifference(
             actionA=CalcMomentSize(
-                colXx=self.colXx,
-                colYy=self.colYy,
-                colXy=self.colXy,
-                sizeType=self.sizeType,
-            ),
-            actionB=CalcMomentSize(
                 colXx=self.colPsfXx,
                 colYy=self.colPsfYy,
                 colXy=self.colPsfXy,
                 sizeType=self.sizeType,
             ),
+            actionB=CalcMomentSize(
+                colXx=self.colXx,
+                colYy=self.colYy,
+                colXy=self.colXy,
+                sizeType=self.sizeType,
+            ),
         )
 
         # distortion-type ellipticity has a shear response of 2, so we need to
@@ -248,7 +248,7 @@ def __call__(self, data: KeyedData, **kwargs) -> KeyedData:
         eRes = calcEDiff(data, **kwargs)
         eRes /= responsitivity  # type: ignore
         e1Res, e2Res = np.real(eRes), np.imag(eRes)
-        sizeRes = calcSizeResidual(data, **kwargs)
+        sizeRes = -1 * calcSizeResidual(data, **kwargs)  # sign flip residual to T_psf - T_model
 
         # Scale the sizeRes by ellipticities
         e1SizeRes = e1 * sizeRes