Skip to content

[BUG] Polling command does not check response #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sstefanov opened this issue Mar 30, 2025 · 2 comments
Open

[BUG] Polling command does not check response #1088

sstefanov opened this issue Mar 30, 2025 · 2 comments

Comments

@sstefanov
Copy link

Describe the bug

I have Anet A8 printer with added ESP3D. Added is filament sensor. Marlin is updated to 2.0.4 with filament sensor support.

I set polling every 5 seconds with M105 command to display temperatures. The problem appears when printer is paused for filament change. After change and resuming print, there is message "Click to resume ...". I found this is due to buffer overflow caused by M105 command.
https://3dprinting.stackexchange.com/questions/7217/what-triggers-marlins-click-to-resume

Seems that ESP3D does not check command response and blindly send next commands. This produce buffer overflow in printer controller.

To Reproduce

  1. Start printing
  2. Click pause printing or remove filament to start Change filament procedure
  3. Wait couple of minutes
  4. Resume print

Expected behavior

After resume print this message should not be seen and print should resume without additional operator input.

ESP3D Firmware:

  • ESP3D FW version: 3.0.0.2b1
  • ESP3D-WebUI Version: 3.0.0-4b1.M2.1
  • Flash method: PlatformIO
  • Any change done in FW:
    None

Target Firmware:

  • Name: Marlin
  • Version: 2.0.4

Board used (please complete the following information):

  • MCU: ESP8266
  • Name: ESP-01
  • Flash size: 1M
@sstefanov sstefanov added the bug label Mar 30, 2025
Copy link

Thank your for submiting, please be sure you followed template or your issue may be dismissed. if you deleted the template it is here

@luc-github
Copy link
Owner

luc-github commented Mar 30, 2025

buffer overflow from who ? Marlin ? => Marlin Issue, it should handle
And no, polling command do not wait for response, this is by design

if you want workaround set Marlin to do Auto repport for temperature and disable polling command in WebUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants