Skip to content

SVS: Pre-run review fails open on agent timeout/exception #23

@lukacf

Description

@lukacf

Problem\nPre-run review currently approves runs when the agent times out or throws an exception. This is a fail-open behavior even when SVS is enabled. See src/goldfish/pre_run_review.py (exception handlers return approved=True).\n\n### Impact\nA failed or misconfigured agent (expired API key, CLI missing, timeout) silently allows long GPU runs to proceed despite the safety check being enabled.\n\n### Suggested Fix\nIf SVS is enabled, failed/timeout reviews should either block or require explicit bypass. At minimum, make this behavior explicit and configurable.\n\n### References\n- src/goldfish/pre_run_review.py timeout/exception handlers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions