Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with Object.assign #2

Closed
lukeed opened this issue Jul 24, 2017 · 3 comments
Closed

Replace with Object.assign #2

lukeed opened this issue Jul 24, 2017 · 3 comments
Labels

Comments

@lukeed
Copy link
Owner

lukeed commented Jul 24, 2017

Replace the inline assign helper with Object.assign

PRO

  • Bundlers can inject replacement
  • Shave Bytes

CON

  • Lose IE support out of the box
    • likely affect UMD entry only

Reference: kristoferbaxter/preact-hn#16

@lukeed lukeed added the maybe label Jul 24, 2017
@xtuc
Copy link

xtuc commented Jul 24, 2017

If you use the spread operator with the Babel plugin it already injects a polyfill of Object.assign.

@lukeed
Copy link
Owner Author

lukeed commented Jul 24, 2017

Right, but I think most people already have transform-object-assign in use. Plus, if I'm going to open the door to builders, I want to be Bublé-friendly, too -- which also will recognize Object.assign as written.

@lukeed
Copy link
Owner Author

lukeed commented Jul 26, 2017

Closed in 43f87b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants