Non-critical code fixes

Author: lumian

webui/application/controllers/Api.php

@@ -7,7 +7,7 @@
 	Description:	API for GRCentral.
 	API version:	v1
 	
-	2020-2021 (c) Copyright GRCentral
+	2020-2024 (c) Copyright GRCentral
 	Get this on Github: http://github.com/lumian/grcentral
 ****************************************************************/
 
@@ -111,7 +111,7 @@ public function v1($query_category=NULL,$param1=NULL,$param2=NULL)
 				// RU: Получение информации о моделях устройств
 				if (!is_null($param1) AND $param1 != FALSE AND !is_null($param2) AND $param2 != FALSE)
 				{
-					$query_result = $this->v1_device_models_get($param1, $param2);
+					$query_result = $this->_v1_device_models_get($param1, $param2);
 				}
 			}
 		}
@@ -288,7 +288,7 @@ private function _v1_device_get($type=NULL, $subtype=NULL)
 		return $result;
 	}
 
-	private function v1_device_models_get($type=NULL, $subtype=NULL)
+	private function _v1_device_models_get($type=NULL, $subtype=NULL)
 	{
 		$this->load->model('settings_model');
 

webui/application/controllers/Auth.php

@@ -6,7 +6,7 @@
 	File:			application\controllers\Auth.php
 	Description:	Controller for user authorization
 	
-	2020-2021 (c) Copyright GRCentral
+	2020-2024 (c) Copyright GRCentral
 	Get this on Github: http://github.com/lumian/grcentral
 ****************************************************************/
 
@@ -30,7 +30,7 @@ public function login()
 
 		if ($is_user == TRUE) 
 		{
-			$this->_back_redirect();
+			redirect(index_page());
 		}
 
 		if (!is_null($this->input->post('login')) AND !is_null($this->input->post('password')))
@@ -47,7 +47,7 @@ public function login()
 				$this->session->set_flashdata('error_result', lang('main_message_autherror'));
 			}
 
-			$this->_back_redirect();
+			redirect(index_page());
 		}
 		else
 		{
@@ -59,19 +59,7 @@ public function logout()
 	{
 		$this->session->unset_userdata('logged_in');
 		$this->session->set_flashdata('success_result', lang('main_message_authlogout'));
-		$this->_back_redirect();
-	}
-	
-	private function _back_redirect()
-	{
-		if (isset($_SERVER["HTTP_REFERER"]) AND mb_stripos($_SERVER["HTTP_REFERER"],base_url()) == '0')
-		{
-			redirect($_SERVER["HTTP_REFERER"]);
-		}
-		else
-		{
-			redirect(index_page());
-		}
+		redirect(index_page());
 	}
 
 	private function _check_credentials($login=NULL, $password=NULL)

webui/application/libraries/Grcentral.php

@@ -6,7 +6,7 @@
 	File:			application\libraries\Grcentral.php
 	Description:	Small but necessary functions that are used in different system controllers.
 	
-	2020-2021 (c) Copyright GRCentral
+	2020-2024 (c) Copyright GRCentral
 	Get this on Github: http://github.com/lumian/grcentral
 ****************************************************************/
 
@@ -161,7 +161,7 @@ public function return_bytes($size_str)
 
 	public function installed_check($action = 'redirect')
 	{
-		if ($this->CI->config->item('system_installed') != TRUE)
+		if ($this->CI->config->item('system_installed') !== TRUE)
 		{
 			$this->correct_baseurl();
 
@@ -188,9 +188,10 @@ public function installed_check($action = 'redirect')
 
 	public function correct_baseurl()
 	{
+		$hostname = $this->CI->input->server('HTTP_HOST');
 		$scheme = $this->get_system_protocol();
 		$system_path = $this->get_system_path();
-		$base_url = $scheme.'://'.$_SERVER['HTTP_HOST'].$system_path;
+		$base_url = $scheme.'://'.$hostname.$system_path;
 		$this->CI->config->set_item('base_url', $base_url);
 	}