Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darknet shortcut support for new fork #410

Closed
HagegeR opened this issue Jan 10, 2020 · 6 comments
Closed

Darknet shortcut support for new fork #410

HagegeR opened this issue Jan 10, 2020 · 6 comments
Assignees

Comments

@HagegeR
Copy link

HagegeR commented Jan 10, 2020

Hi @lutzroeder ,

I think that the from parameter is not implemented correctly.

A correct implementation is detailed here : AlexeyAB/darknet#4662

I'm not sure that #335 is completely correct: from what I understand by the code, only [scale_channel] implement partially the from attribute, [shortcut] and [sam] layer should implement it too.

thanks for your help lately with the darknet implementation!

@lutzroeder
Copy link
Owner

lutzroeder commented Jan 10, 2020

@HagegeR, can you create a fix and submit a PR.

@lutzroeder lutzroeder changed the title Correct Darknet Shortcut Darknet shortcut for new AlexeyAB fork Jan 10, 2020
@lutzroeder lutzroeder changed the title Darknet shortcut for new AlexeyAB fork Darknet shortcut support for new fork Jan 10, 2020
@HagegeR
Copy link
Author

HagegeR commented Jan 10, 2020

@lutzroeder I'm not sure how to do it really, how do you get multiple inputs in there:

let index = option_find_int(options, 'from', 0);

@lutzroeder
Copy link
Owner

@HagegeR, check a few lines down for const routes.

@HagegeR
Copy link
Author

HagegeR commented Jan 13, 2020

@HagegeR
Copy link
Author

HagegeR commented Jan 15, 2020

@lutzroeder hi, is this ok?

@lutzroeder
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants