Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcmanfm causes the archive manager to crash. #84

Closed
babam86 opened this issue Nov 28, 2021 · 1 comment
Closed

Pcmanfm causes the archive manager to crash. #84

babam86 opened this issue Nov 28, 2021 · 1 comment

Comments

@babam86
Copy link

babam86 commented Nov 28, 2021

File Roller and Engrampa (archive manager) crash when extracting by drag and drop files across a Desktop file (*.desktop).

It's not a File Roller or Engrampa fault, File Roller and Engrampa with Thunar works fine.
Screenshot_2021-11-28_19-49-31

@ib
Copy link
Member

ib commented Nov 16, 2024

Is this bug the same as the one reported in #45? If not, please describe exactly what you mean by "crash" and when exactly what happens during the drag and drop.

ib added a commit that referenced this issue Dec 3, 2024
For internal drag and drop (from folder view to side pane), a call to
fm_dnd_dest_get_default_action() is required during the drag motion to
determine the GdkDragAction to take.

Due to the change in commit 1d7738c and
because the dest variable is NULL in the case of XDirectSave, a call to
gtk_drag_get_data() is made not only for the internal drag and drop, but
also for XDirectSave during the drag motion, followed by a call to
gtk_drag_finish() later, without any drop having taken place.

What seems to be necessary for the internal drag and drop will cause an
XDirectSave drag and drop to freeze.

So in case of XDirectSave, get its GdkDragAction and immediately return
from fm_dnd_dest_get_default_action().

This closes github issue #45, reported by CasperVector,
likely github issue #84, reported by babam86,
https://sourceforge.net/p/pcmanfm/bugs/572,
and https://sourceforge.net/p/pcmanfm/bugs/1126.
@ib ib removed the question label Dec 3, 2024
@ib ib closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants