Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help] Is there any way to dump the excluded links? #587

Closed
Rizwan-Hasan opened this issue Apr 7, 2022 · 6 comments · Fixed by #615
Closed

[Help] Is there any way to dump the excluded links? #587

Rizwan-Hasan opened this issue Apr 7, 2022 · 6 comments · Fixed by #615
Labels
enhancement New feature or request workaround

Comments

@Rizwan-Hasan
Copy link

Using the --dump we can get all the links extracted from inputs that would be checked.
Is there any way to get the excluded links also?

@Rizwan-Hasan Rizwan-Hasan changed the title Is there any to dump the excluded links? [Help]Is there any to dump the excluded links? Apr 7, 2022
@Rizwan-Hasan Rizwan-Hasan changed the title [Help]Is there any to dump the excluded links? [Help] Is there any to dump the excluded links? Apr 7, 2022
@Rizwan-Hasan Rizwan-Hasan changed the title [Help] Is there any to dump the excluded links? [Help] Is there any way to dump the excluded links? Apr 7, 2022
@lebensterben
Copy link
Member

I think you can extract it from json output with jq.

@Rizwan-Hasan
Copy link
Author

I've tried with --format json , it's giving me failed links with statistics or only statistics (if nofail). But not giving excluded links.

@mre
Copy link
Member

mre commented Apr 7, 2022

There is #268, where we could add the excluded links maybe.
Perhaps we should dump the excluded links if the --verbose flag is set? That feature would not be easy to discover, though. Alternatively we could use --dump-excluded, but it feels like it's a niche use-case and I don't want to clutter the help output with too many special cases.

If we can find a straightforward way to do it, I'm all for adding that functionality. Open for suggestions.

@mre
Copy link
Member

mre commented Apr 7, 2022

Well actually we could just append [excluded] to every excluded link when using --dump. 🤔
Similar for cached links etc. Then you could just grep for that. @lebensterben what do you think?

@lebensterben
Copy link
Member

@mre
We might as well include reason for exclusion, at least for verbose output.

@mre mre added enhancement New feature or request workaround labels Apr 12, 2022
mre added a commit that referenced this issue May 11, 2022
This is a minimally invasive version, which allows to grep for `[excluded]`.
The reason for exclusion would require more work and it's debatable if
it adds any value, because it might make grepping harder and the source
of exclusion is easily deducatable from the commandline parameters
or the `.lycheeignore` file.

Fixes #587.
mre added a commit that referenced this issue May 11, 2022
This is a minimally invasive version, which allows to grep for `[excluded]`.
The reason for exclusion would require more work and it's debatable if
it adds any value, because it might make grepping harder and the source
of exclusion is easily deducatable from the commandline parameters
or the `.lycheeignore` file.

Fixes #587.
@mre mre closed this as completed in #615 May 13, 2022
mre added a commit that referenced this issue May 13, 2022
This is a minimally invasive version, which allows to grep for `[excluded]`.
The reason for exclusion would require more work and it's debatable if
it adds any value, because it might make grepping harder and the source
of exclusion is easily deducatable from the commandline parameters
or the `.lycheeignore` file.

Fixes #587.
@mre
Copy link
Member

mre commented May 13, 2022

I went ahead and merged this to master.
The reason for exclusion would require more work and it's debatable if
it adds any value, because it might make grepping harder and the source
of exclusion is easily deducatable from the commandline parameters
or the .lycheeignore file, so I skipped that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants