Skip to content

Fix #8: WebSerial Communication Issues with Ender 3 v2 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkymut wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix #8: WebSerial Communication Issues with Ender 3 v2 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f955e4b
add exportGcode method to download gcode file
nkymut Jun 22, 2023
f8fa8dc
add finishPrint sequence
nkymut Jun 22, 2023
e940154
Merge branch 'finishPrint' of https://github.com/nkymut/p5.fab
nkymut Jun 22, 2023
09f1dcf
add export gcode menu item to the editor
nkymut Jun 22, 2023
1e1ac88
Merge remote-tracking branch 'upstream/main' into upgrade
nkymut Dec 5, 2024
9e4ec2c
fix: Ender3 v2 WebSerial connection issue #8
nkymut Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ <h1>p5.fab</h1>
<div class="menu-item" onclick="evaluateJs('_fab.serial.requestPort();')">connect</div>
<div class="menu-item" onclick="evaluateJs('_fab.print();')">start print</div>
<div class="menu-item" onclick="evaluateJs('_fab.stopPrint();')">stop print</div>
<div class="menu-item" onclick="evaluateJs('_fab.exportGcode();')">export gcode</div>
<a href="https://github.com/machineagency/p5.fab" target="_blank" rel="noopener noreferrer"
id="top-bar-link">source</a>
<div class="menu-item" onclick="showInfoModal()">info</div>
Expand Down
17 changes: 12 additions & 5 deletions examples/2.5D-sketching/sketch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,23 @@ function setup() {
fab.serial.requestPort(); // choose the serial port to connect to
});

let printButton = createButton("print!");
printButton.position(20, 60);
printButton.mousePressed(function () {
fab.print(); // start streaming the commands to printer
let startButton = createButton('start!');
startButton.position(20, 60);
startButton.mousePressed(function () {
fab.print(); // start streaming commands to printer
});

let stopButton = createButton("stop!");
let stopButton = createButton('stop!');
stopButton.position(20, 100);
stopButton.mousePressed(function () {
fab.stopPrint(); // stop streaming the commands to printer
});

let exportButton = createButton('export!');
exportButton.position(20, 140);
exportButton.mousePressed(function () {
fab.exportGcode(); // export gcode to a file.
});
}

function fabDraw() {
Expand Down Expand Up @@ -52,6 +58,7 @@ function fabDraw() {
r -= 0.1;
}
fab.presentPart();
//console.log(fab.commands);
}

function draw() {
Expand Down
2 changes: 1 addition & 1 deletion examples/control-panel/sketch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function fabDraw() {
}

function connectPrinter() {
fab.serial.requestPort();
fab.connectPrinter();
}

function bSend(dir) {
Expand Down
6 changes: 6 additions & 0 deletions examples/hollow-cube/sketch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ function setup() {
stopButton.mousePressed(function() {
fab.stopPrint(); // stop streaming the commands to printer
});

let exportButton = createButton('export!');
exportButton.position(20, 140);
exportButton.mousePressed(function() {
fab.exportGcode(); // export gcode to a file.
});
}

function fabDraw() {
Expand Down
7 changes: 7 additions & 0 deletions examples/line-vase/sketch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ function setup() {
stopButton.mousePressed(function() {
fab.stopPrint(); // stop streaming the commands to printer
});

let exportButton = createButton('export!');
exportButton.position(20, 140);
exportButton.mousePressed(function() {
fab.exportGcode(); // export gcode to a file.
});

}


Expand Down
6 changes: 6 additions & 0 deletions examples/template/sketch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ function setup() {
fab.stopPrint(); // stop streaming the commands to printer.
});

let exportButton = createButton('export!');
exportButton.position(20, 140);
exportButton.mousePressed(function() {
fab.exportGcode(); // export gcode to a file.
});

}


Expand Down
16 changes: 14 additions & 2 deletions examples/vase/sketch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,29 @@ function setup() {
fab = createFab();

// add a buttons to connect to the printer & to print!
connectButton = createButton('connect!');
let connectButton = createButton('connect!');
connectButton.position(20, 20);
connectButton.mousePressed(function() {
fab.serial.requestPort();
});

printButton = createButton('print!');
let printButton = createButton('print!');
printButton.position(20, 60);
printButton.mousePressed(function() {
fab.print();
});

let stopButton = createButton('stop!');
stopButton.position(20, 100);
stopButton.mousePressed(function() {
fab.stopPrint(); // stop streaming the commands to printer.
});

let exportButton = createButton('export!');
exportButton.position(20, 140);
exportButton.mousePressed(function() {
fab.exportGcode(); // export gcode to a file.
});
}

function draw() {
Expand Down
Loading