Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

known_fail should not be seen as a build success #344

Open
kencu opened this issue Jun 23, 2022 · 6 comments
Open

known_fail should not be seen as a build success #344

kencu opened this issue Jun 23, 2022 · 6 comments

Comments

@kencu
Copy link

kencu commented Jun 23, 2022

when a port sets known_fail on a system version, it should be displayed as a fail in the webapp, not a success

@mascguy
Copy link
Member

mascguy commented Jun 23, 2022

I'd prefer that we have a 3rd status - like "not supported," or something akin to that - to differentiate from a simple success/failure.

Anyone else... thoughts?

@kencu
Copy link
Author

kencu commented Jun 23, 2022

Anything but success

@jmroot
Copy link
Member

jmroot commented Jun 23, 2022

AFAIK, you currently see the grey question mark for known_fail ports, since no build takes place. An indicator that it is known to fail rather than just not built would be nice.

Of course if there was a successful build of a previous version, #135 will be in effect.

@mascguy
Copy link
Member

mascguy commented Jun 25, 2022

Similarly, if there was at least one build failure prior to setting known_fail, that will also be in effect.

And that can be a bit frustrating, when drilling down the dependency tree.

@ryandesign
Copy link
Contributor

AFAIK, you currently see the grey question mark for known_fail ports, since no build takes place. An indicator that it is known to fail rather than just not built would be nice.

Only if no build of that port (any version) has ever taken place on that builder. If a build has taken place in the past, then that information is displayed by the web app even if it is outdated. Ideally the web app would not display outdated information.

@jmroot
Copy link
Member

jmroot commented Dec 28, 2022

Yes, hence the reference to #135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants