-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMM pre-processing fails if sampling rate is not a multiple of 51.2 #59
Comments
I could take care of it. I am not 100% on this topic; never used the HMMs so far. My naive approach would be to use the @AKuederle @HaMora what di you think? |
Seems reasonable. Does resample support a "nearest" option? Otherwise interpolate might do the job |
I mean as a resample method. Because we need discrete values. With normal resample you would get float/in-between values |
And yes, the green signal is the one that needs resampling |
Sorry for the late reply, |
Resolved by #62 |
The "naive" upsampling implemnted here does not work with samplingrates that are not a even multiple
gaitmap/gaitmap_mad/gaitmap_mad/stride_segmentation/hmm/_hmm_feature_transform.py
Lines 261 to 277 in 8510fe0
We should use proper interpolation using "nearest"
@HaMora @Aksei Jelena wanted to fix this I think? Any updates? And if she does not have time, could one of you have a look at that?
The text was updated successfully, but these errors were encountered: