Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot testing util does not work with datatime index #92

Closed
AKuederle opened this issue Sep 14, 2023 · 3 comments · Fixed by #97
Closed

Snapshot testing util does not work with datatime index #92

AKuederle opened this issue Sep 14, 2023 · 3 comments · Fixed by #97
Assignees

Comments

@AKuederle
Copy link
Member

When trying to save a pandas df with a datetime index with the snapshot test, the roundtrip does not work, as pandas seems to round the timestamps before saving.

A workaround is to round the timestamps to ms before applying the snapshot, but we should just directly integrate this workaround in the testing tools

@AKuederle
Copy link
Member Author

Had to reopen the issue, as I am still having trouble with that for some ns-timestamps. Will investigate further.
For now old workaround is still valid

@a-mosquito
Copy link
Collaborator

Maybe this is related to this issue?

@AKuederle
Copy link
Member Author

Actually fixed by #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants