Merge pull request #501 from magento-pangolin/3.0.0-RC3-1.4.0

omiroshnichenko · web-flow · commit df2c8fec6f8b · 2020-06-02T13:04:29.000-05:00
[1.4.0-release] MQE-2113: fix errors reported by the static check
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoAlignmentEmptyBorderRadiusActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoAlignmentEmptyBorderRadiusActionGroup.xml
@@ -11,7 +11,6 @@
         <arguments>
             <argument name="page" defaultValue=""/>
             <argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
-            <argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
             <argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthPropertyDefault"/>
             <argument name="margin" defaultValue="PageBuilderMarginsPropertyDefault"/>
             <argument name="padding" defaultValue="PageBuilderPaddingPropertyDefault"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoBorderWidthActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoBorderWidthActionGroup.xml
@@ -10,7 +10,6 @@
     <actionGroup name="validateAdvancedStyleWithNoBorderWidth">
         <arguments>
             <argument name="page" defaultValue=""/>
-            <argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyDefault"/>
             <argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
             <argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
             <argument name="margin" defaultValue="PageBuilderMarginsPropertyDefault"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeColumnActionGroup/DragColumnToAnotherColumnGroupActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeColumnActionGroup/DragColumnToAnotherColumnGroupActionGroup.xml
@@ -11,7 +11,6 @@
         <arguments>
             <argument name="contentType" defaultValue="PageBuilderColumnContentType"/>
             <argument name="contentTypeIndex" defaultValue="1" type="string"/>
-            <argument name="containerTargetType" defaultValue="PageBuilderColumnContentType"/>
             <argument name="containerTargetIndex" defaultValue="1" type="string"/>
             <argument name="x" defaultValue="10" type="string"/>
             <argument name="y" defaultValue="0" type="string"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/EnterHeadingOnStageActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/EnterHeadingOnStageActionGroup.xml
@@ -10,7 +10,6 @@
     <actionGroup name="enterHeadingOnStage">
         <arguments>
             <argument name="index" defaultValue="1" type="string"/>
-            <argument name="headingText" defaultValue="PageBuilderHeadingTextProperty"/>
             <argument name="headingType" defaultValue="PageBuilderHeadingTypeDefaultProperty"/>
             <argument name="headingAlignment" defaultValue="PageBuilderHeadingAlignmentProperty_left"/>
         </arguments>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/VerifyHeadingInStorefrontActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/VerifyHeadingInStorefrontActionGroup.xml
@@ -9,7 +9,6 @@
 	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="verifyHeadingInStorefront">
         <arguments>
-            <argument name="page" defaultValue=""/>
             <argument name="headingType" defaultValue="PageBuilderHeadingTypeDefaultProperty"/>
             <argument name="headingText" defaultValue="PageBuilderHeadingTextProperty"/>
             <argument name="index" defaultValue="1" type="string"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/VerifyHeadingInStorefrontWithAlignmentActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/VerifyHeadingInStorefrontWithAlignmentActionGroup.xml
@@ -9,7 +9,6 @@
 	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="verifyHeadingInStorefrontWithAlignment">
         <arguments>
-            <argument name="page" defaultValue=""/>
             <argument name="headingType" defaultValue="PageBuilderHeadingTypeDefaultProperty"/>
             <argument name="headingText" defaultValue="PageBuilderHeadingTextProperty"/>
             <argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup/ClickProductAddToWishListInContinuousProductsCarouselOnStorefrontActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup/ClickProductAddToWishListInContinuousProductsCarouselOnStorefrontActionGroup.xml
@@ -9,7 +9,6 @@
 	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="clickProductAddToWishListInContinuousProductsCarouselOnStorefront">
         <arguments>
-            <argument name="product" type="string"/>
             <argument name="productItemIndex" defaultValue="1" type="string"/>
             <argument name="productGroupIndex" defaultValue="1" type="string"/>
         </arguments>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeVideoActionGroup/ValidateVideoPlayingActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeVideoActionGroup/ValidateVideoPlayingActionGroup.xml
@@ -13,7 +13,6 @@
         </annotations>
         <arguments>
             <argument name="page" defaultValue="VideoOnStage"/>
-            <argument name="url" defaultValue="PageBuilderVideoUrl_Empty"/>
             <argument name="index" defaultValue="1" type="string"/>
         </arguments>
         <waitForPageLoad stepKey="waitForPageLoad"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup/HideSmallContentTypeActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup/HideSmallContentTypeActionGroup.xml
@@ -12,8 +12,6 @@
             <argument name="section"/>
             <argument name="contentType"/>
             <argument name="targetIndex" defaultValue="1" type="string"/>
-            <argument name="x" defaultValue="null" type="string"/>
-            <argument name="y" defaultValue="null" type="string"/>
         </arguments>
         <!-- Hiding content type -->
         <comment userInput="Hiding content type" stepKey="commentHideContentType"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup/ShowSmallContentTypeActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup/ShowSmallContentTypeActionGroup.xml
@@ -12,8 +12,6 @@
             <argument name="section"/>
             <argument name="contentType"/>
             <argument name="targetIndex" defaultValue="1" type="string"/>
-            <argument name="x" defaultValue="null" type="string"/>
-            <argument name="y" defaultValue="null" type="string"/>
         </arguments>
         <!-- Showing content type -->
         <comment userInput="Showing content type" stepKey="commentShowContentType"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/AddPageLinkWidgetToTinyMCE3ActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/AddPageLinkWidgetToTinyMCE3ActionGroup.xml
@@ -9,7 +9,6 @@
 	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="addPageLinkWidgetToTinyMCE3" extends="addPageLinkWidgetToTinyMCE">
         <arguments>
-            <argument name="widget" defaultValue=""/>
             <argument name="page" defaultValue="" type="string"/>
         </arguments>
         <comment userInput="Adding Widget To TinyMCE3" stepKey="commentAddWidget"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/AddPageLinkWidgetToTinyMCEActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/AddPageLinkWidgetToTinyMCEActionGroup.xml
@@ -9,7 +9,6 @@
 	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="addPageLinkWidgetToTinyMCE">
         <arguments>
-            <argument name="widget" defaultValue=""/>
             <argument name="page" defaultValue="" type="string"/>
         </arguments>
         <comment userInput="Adding Widget To Tiny MCE" stepKey="commentAddWidget"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/DoubleClickWidgetTinyMCEActionGroup.xml b/app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/DoubleClickWidgetTinyMCEActionGroup.xml
@@ -10,8 +10,6 @@
     <actionGroup name="doubleClickWidgetTinyMCE">
         <arguments>
             <argument name="section" defaultValue="TextOnStage"/>
-            <argument name="index" defaultValue="1" type="string"/>
-            <argument name="widget"/>
         </arguments>
         <waitForElementVisible selector="{{section.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="waitForWidgetVisible"/>
         <doubleClick selector="{{section.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="doubleClickOnWidgetPlaceholder"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDeleteContentTypesFromOnClickOptionMenusTest.xml b/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDeleteContentTypesFromOnClickOptionMenusTest.xml
@@ -11,8 +11,8 @@
         <annotations>
             <features value="PageBuilder"/>
             <stories value="CMS Block"/>
-            <title value="Verify that user can delete content types from on-hover option menus in CMS Block"/>
-            <description value="This test is intended to ensure that users can delete content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
+            <title value="Verify that user can delete content types from on-click option menus in CMS Block"/>
+            <description value="This test is intended to ensure that users can delete content types from the on-click option menus within the PageBuilder stage for CMS Block."/>
             <severity value="CRITICAL"/>
             <useCaseId value="MC-3328"/>
             <testCaseId value="MC-13762"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDuplicateContentTypesFromOnClickOptionMenusTest.xml b/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDuplicateContentTypesFromOnClickOptionMenusTest.xml
@@ -11,8 +11,8 @@
         <annotations>
             <features value="PageBuilder"/>
             <stories value="CMS Block"/>
-            <title value="Verify that user can duplicate content types from on-hover option menus in CMS Block"/>
-            <description value="This test is intended to ensure that users can duplicate content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
+            <title value="Verify that user can duplicate content types from on-click option menus in CMS Block"/>
+            <description value="This test is intended to ensure that users can duplicate content types from the on-click option menus within the PageBuilder stage for CMS Block."/>
             <severity value="MAJOR"/>
             <useCaseId value="MC-3328"/>
             <testCaseId value="MC-13760"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnClickOptionMenusTest.xml b/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnClickOptionMenusTest.xml
@@ -11,8 +11,8 @@
         <annotations>
             <features value="PageBuilder"/>
             <stories value="CMS Block"/>
-            <title value="Verify that user can edit content types from on-hover option menus in CMS Block"/>
-            <description value="This test is intended to ensure that users can edit content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
+            <title value="Verify that user can edit content types from on-click option menus in CMS Block"/>
+            <description value="This test is intended to ensure that users can edit content types from the on-click option menus within the PageBuilder stage for CMS Block."/>
             <severity value="BLOCKER"/>
             <useCaseId value="MC-3328"/>
             <testCaseId value="MC-13759"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnHoverOptionMenusTest.xml b/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnHoverOptionMenusTest.xml
@@ -11,8 +11,8 @@
         <annotations>
             <features value="PageBuilder"/>
             <stories value="CMS Block"/>
-            <title value="Verify that user can move content types from on-hover option menus in CMS Block"/>
-            <description value="This test is intended to ensure that users can move content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
+            <title value="Verify that user can edit content types from on-hover option menus in CMS Block"/>
+            <description value="This test is intended to ensure that users can edit content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
             <severity value="BLOCKER"/>
             <useCaseId value="MC-3328"/>
             <testCaseId value="MC-13751"/>
diff --git a/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderVideoTest/VideoValidateAutoplayDisabled.xml b/app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderVideoTest/VideoValidateAutoplayDisabled.xml
@@ -11,7 +11,7 @@
         <annotations>
             <features value="PageBuilder"/>
             <stories value="Video"/>
-            <title value="Validate Video Autoplay Attribute"/>
+            <title value="Validate Video Autoplay Attribute - Disabled"/>
             <description value="Validate that setting the autoplay attribute in the General form for Video will update the Stage and Storefront correctly."/>
             <severity value="BLOCKER"/>
             <useCaseId value="PB-375"/>
