Skip to content

fix: tutorial on the site is glitchy - #1115

Open
ash-heinz wants to merge 1 commit into
magic-peach:mainfrom
ash-heinz:fix/Tutorial-on-the-site-is-glitchy
Open

fix: tutorial on the site is glitchy#1115
ash-heinz wants to merge 1 commit into
magic-peach:mainfrom
ash-heinz:fix/Tutorial-on-the-site-is-glitchy

Conversation

@ash-heinz

Copy link
Copy Markdown
Contributor

Description

Allow tour target rect to be null and provide fallbacks: center the tooltip when the target element isn't found and render a full-screen dimmer spotlight. Constrain tooltip within the viewport and add a responsive max-width. Change measureTarget to return Rect|null synchronously and add scrollToTarget to attempt scrolling elements into view before measuring. Update startup and step-change logic to scroll-to target, retry fewer times, and re-measure after scrolling; rework retry timing and fallback behavior. Improve scroll/resize handling (passive capture on scroll) and lock page scroll (wheel/touch/keyboard) while the tour is visible. Minor accessibility/focus tweaks to focus the tooltip when available.

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: ash-heinz
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screen Recording

How to record: run bun run dev → open http://localhost:3000 → demonstrate the full working flow of your change, including any edge cases.

  • macOS: Cmd + Shift + 5 → Record Selected Portion, or use QuickTime Player
  • Windows: Win + G → Xbox Game Bar → Capture
  • Linux: OBS Studio, GNOME Screenshot tool, or kazam
  • Any OS: Loom (free screen recorder, great for sharing)

Recording / Loom link: https://drive.google.com/file/d/1eRjtiha7vKWar_gu5xUZGkL5DDQ-Upvn/view?usp=sharing

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in (only statement is one from pre existing issue)
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

closes #982

Allow tour target rect to be null and provide fallbacks: center the tooltip when the target element isn't found and render a full-screen dimmer spotlight. Constrain tooltip within the viewport and add a responsive max-width. Change measureTarget to return Rect|null synchronously and add scrollToTarget to attempt scrolling elements into view before measuring. Update startup and step-change logic to scroll-to target, retry fewer times, and re-measure after scrolling; rework retry timing and fallback behavior. Improve scroll/resize handling (passive capture on scroll) and lock page scroll (wheel/touch/keyboard) while the tour is visible. Minor accessibility/focus tweaks to focus the tooltip when available.
@vercel

vercel Bot commented May 24, 2026

Copy link
Copy Markdown

@ash-heinz is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor labels May 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @ash-heinz!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @ash-heinz

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity.

If you need help with this PR, please comment or ping a maintainer.
Make sure your branch is rebased onto main and all CI checks pass.

@github-actions github-actions Bot added the needs-fixes PR has issues that need to be fixed label Jun 15, 2026
@magic-peach

Copy link
Copy Markdown
Owner

Hi @ash-heinz — good news and a small ask.

Your PR passed review in our backlog cleanup and was queued to merge. We merged 38 PRs today, and yours now conflicts with main purely because of that — several of them touched the same files. Nothing is wrong with your change.

To land it:

git fetch origin
git rebase origin/main
# resolve conflicts
git push --force-with-lease

Ping me here once it's green and I'll merge it straight away — it's already approved on our side, so it won't go back into the queue. Thanks for your patience with how long this sat 🙏

@magic-peach magic-peach added the merge-ready PR is approved and ready to merge label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts merge-ready PR is approved and ready to merge needs-fixes PR has issues that need to be fixed type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Tutorial on the site is glitchy

2 participants