fix: tutorial on the site is glitchy - #1115
Conversation
Allow tour target rect to be null and provide fallbacks: center the tooltip when the target element isn't found and render a full-screen dimmer spotlight. Constrain tooltip within the viewport and add a responsive max-width. Change measureTarget to return Rect|null synchronously and add scrollToTarget to attempt scrolling elements into view before measuring. Update startup and step-change logic to scroll-to target, retry fewer times, and re-measure after scrolling; rework retry timing and fallback behavior. Improve scroll/resize handling (passive capture on scroll) and lock page scroll (wheel/touch/keyboard) while the tour is visible. Minor accessibility/focus tweaks to focus the tooltip when available.
|
@ash-heinz is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @ash-heinz!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @ash-heinzBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity. If you need help with this PR, please comment or ping a maintainer. |
|
Hi @ash-heinz — good news and a small ask. Your PR passed review in our backlog cleanup and was queued to merge. We merged 38 PRs today, and yours now conflicts with To land it: git fetch origin
git rebase origin/main
# resolve conflicts
git push --force-with-leasePing me here once it's green and I'll merge it straight away — it's already approved on our side, so it won't go back into the queue. Thanks for your patience with how long this sat 🙏 |
Description
Allow tour target rect to be null and provide fallbacks: center the tooltip when the target element isn't found and render a full-screen dimmer spotlight. Constrain tooltip within the viewport and add a responsive max-width. Change measureTarget to return Rect|null synchronously and add scrollToTarget to attempt scrolling elements into view before measuring. Update startup and step-change logic to scroll-to target, retry fewer times, and re-measure after scrolling; rework retry timing and fallback behavior. Improve scroll/resize handling (passive capture on scroll) and lock page scroll (wheel/touch/keyboard) while the tour is visible. Minor accessibility/focus tweaks to focus the tooltip when available.
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link: https://drive.google.com/file/d/1eRjtiha7vKWar_gu5xUZGkL5DDQ-Upvn/view?usp=sharing
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in (only statement is one from pre existing issue)closes #982