fix: Wire ? shortcut to keyboard shortcuts panel (#1118)

[Abhi190702]

Summary

Closes #1118

Fixes the disconnected ? keyboard shortcut so it actually toggles the Keyboard Shortcuts panel.

Root Cause

useKeyboardShortcuts() already handled the ? key and called onToggleShortcutsModal(), but VideoEditor.tsx passed a no-op callback:

onToggleShortcutsModal: () => {},

That meant the shortcut was registered but had no visible UI effect.

Changes Made

• Lifted the keyboard shortcuts panel open state into VideoEditor
• Passed a real toggleShortcutsPanel callback into useKeyboardShortcuts
• Made KeyboardShortcutsPanel controlled by parent state while preserving click-to-toggle behavior
• Moved ? handling before the file guard so users can open shortcut help even before uploading a video
• Prevented default behavior for ? shortcut handling
• Added regression tests for:
  • ? toggles shortcut help before a file is loaded
  • ? is ignored while typing in an input

Testing

• bun run lint ✅
• bunx tsc --noEmit ✅
• bun run test -- --run ✅
• bun run build ✅

Manual note: Local dev server responded on http://localhost:3001; browser automation was unavailable in this environment because Playwright is not installed and the Browser tool is not exposed here.

[vercel]

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

👋 Thanks for your PR, @Abhi190702!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
2. ✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
3. 👀 Code review — a maintainer will review your changes
4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

• PR title follows Conventional Commits (e.g. feat: add dark mode)
• Linked the issue this PR closes (e.g. Closes #123)
• Tested the changes locally (bun run dev)
• Build passes (bun run build)

Useful links

• 📖 CONTRIBUTING.md
• 🐛 Open Issues
• ⭐ Star the repo to support the project!

Happy coding! 🎉

[github-actions]

✅ PR Format Check Passed — @Abhi190702

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

[Abhi190702]

@magic-peach , I would be grateful if you can look into this

[Abhi190702]

@magic-peach , Any preceedings ?

[magic-peach]

Hi @Abhi190702 — good news and a small ask.

Your PR passed review in our backlog cleanup and was queued to merge. We merged 38 PRs today, and yours now conflicts with main purely because of that — several of them touched the same files. Nothing is wrong with your change.

To land it:

git fetch origin
git rebase origin/main
# resolve conflicts
git push --force-with-lease

Ping me here once it's green and I'll merge it straight away — it's already approved on our side, so it won't go back into the queue. Thanks for your patience with how long this sat 🙏