fix: add data-testid attributes to key UI elements - #560
Conversation
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Thanks for your PR, @TanviHanda!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
Hey @TanviHanda! Thanks for adding Please remove it: rm package-lock.json
git add package-lock.json
git commit -m "chore: remove package-lock.json"
git pushOnce removed and CI passes, the testid additions will be reviewed! |
|
Hey @TanviHanda! Adding data-testid attributes for testing is a useful contribution. This PR has merge conflicts with git fetch origin
git rebase origin/main
git push --force-with-lease |
|
Hey @TanviHanda! This PR has merge conflicts with the latest git fetch origin
git rebase origin/main
git push --force-with-leaseOnce CI (build/lint/typecheck) passes, we'll review and merge! |
067b5fe to
03e1be8
Compare
|
Hey @TanviHanda! This PR looks good in terms of code structure, but the build/lint/typecheck CI hasn't run yet. Please rebase onto the latest git fetch upstream
git rebase upstream/main
git push --force-with-leaseOnce CI passes, we'll review and merge! |
03e1be8 to
7fb06cd
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/magic-peach1s-projects?upgradeToPro=build-rate-limit |
|
Hey @TanviHanda! 👋 We've added a new requirement for all PRs: a screen recording showing your changes working on your local machine must be attached before a PR can be merged. Please add a recording to this PR that shows:
How to record:
Once you have the recording, drag the file directly into a comment on this PR, or paste a Loom link. This is now a hard requirement — see CONTRIBUTING.md for full details. Thanks for contributing to Reframe! 🎬 |
|
Hey @magic-peach Added the screen recording showing the app running locally, the implemented flow working end-to-end, and the required UI elements with data-testid attributes. |
|
Hi @magic-peach , I resolved the merge conflict and pushed the updated branch. The remaining failed checks seem to be related to Vercel/Claude bot limits or external review/deployment issues. Please let me know if any code changes are needed from my side. |
|
Hey @TanviHanda! This PR has merge conflicts with git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseOnce rebased and CI passes, this can be reviewed for merge. |
c7d1d26 to
3e37f88
Compare
cd3c87f to
a134363
Compare
a134363 to
174bbde
Compare
|
@TanviHanda Adding git fetch origin
git rebase origin/main
git push --force-with-leaseAlso please fill in the PR description with what specific elements got |
|
Hi @magic-peach The remaining failing check is Vercel deployment authorization, which requires maintainer/team permissions.
|
|
Hi @TanviHanda — thanks for this, and sorry for the wait. I'd like to get this merged, but it replaces a To get it unblocked:
Could you take a look within the next 14 days? If I don't hear back by then I'll close it to keep the queue manageable — but you're very welcome to reopen it any time after that. Thanks again for contributing to Reframe 🙏 |
|
Hi @magic-peach |

Close Issue number #56
Description
What changed
Added
data-testidattributes to key UI elements for better automated testing support.Updated components
Purpose
This improves element targeting and reliability for end-to-end/UI tests.