Skip to content

fix: add data-testid attributes to key UI elements - #560

Open
TanviHanda wants to merge 2 commits into
magic-peach:mainfrom
TanviHanda:add-testid-attributes
Open

fix: add data-testid attributes to key UI elements#560
TanviHanda wants to merge 2 commits into
magic-peach:mainfrom
TanviHanda:add-testid-attributes

Conversation

@TanviHanda

@TanviHanda TanviHanda commented May 17, 2026

Copy link
Copy Markdown

Close Issue number #56

Description

What changed

Added data-testid attributes to key UI elements for better automated testing support.

Updated components

  • FileUpload
  • VideoEditor
  • ExportOverlay
  • ExportSettings
  • DownloadResult
  • AudioSpeedControl

Purpose

This improves element targeting and reliability for end-to-end/UI tests.

@vercel

vercel Bot commented May 17, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @TanviHanda

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @TanviHanda!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 17, 2026
@TanviHanda TanviHanda closed this May 17, 2026
@TanviHanda TanviHanda reopened this May 17, 2026
@TanviHanda TanviHanda changed the title Add data-testid attributes to key UI elements fix: add data-testid attributes to key UI elements May 17, 2026
@magic-peach

Copy link
Copy Markdown
Owner

Hey @TanviHanda! Thanks for adding data-testid attributes — these are useful for testing. However, package-lock.json (7k lines) has been committed to this PR. This project uses bun.lock exclusively.

Please remove it:

rm package-lock.json
git add package-lock.json
git commit -m "chore: remove package-lock.json"
git push

Once removed and CI passes, the testid additions will be reviewed!

@magic-peach magic-peach added level:beginner Beginner level - 20 pts type:testing Testing and removed level:advanced Advanced level - 55 pts type:feature New feature type:docs Documentation type:design UI/UX design labels May 17, 2026
@magic-peach

Copy link
Copy Markdown
Owner

Hey @TanviHanda! Adding data-testid attributes for testing is a useful contribution. This PR has merge conflicts with main. Please rebase:

git fetch origin
git rebase origin/main
git push --force-with-lease

@github-actions github-actions Bot added type:design UI/UX design type:docs Documentation type:feature New feature labels May 17, 2026
@magic-peach

Copy link
Copy Markdown
Owner

Hey @TanviHanda! This PR has merge conflicts with the latest main. Please rebase to resolve them and trigger fresh CI:

git fetch origin
git rebase origin/main
git push --force-with-lease

Once CI (build/lint/typecheck) passes, we'll review and merge!

@TanviHanda
TanviHanda force-pushed the add-testid-attributes branch from 067b5fe to 03e1be8 Compare May 18, 2026 03:01
@magic-peach

Copy link
Copy Markdown
Owner

Hey @TanviHanda! This PR looks good in terms of code structure, but the build/lint/typecheck CI hasn't run yet. Please rebase onto the latest main to trigger fresh checks:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

Once CI passes, we'll review and merge!

@TanviHanda
TanviHanda force-pushed the add-testid-attributes branch from 03e1be8 to 7fb06cd Compare May 18, 2026 14:44
@github-actions github-actions Bot added the level:intermediate Intermediate level - 35 pts label May 18, 2026
@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/magic-peach1s-projects?upgradeToPro=build-rate-limit

@magic-peach

Copy link
Copy Markdown
Owner

Hey @TanviHanda! 👋

We've added a new requirement for all PRs: a screen recording showing your changes working on your local machine must be attached before a PR can be merged.

Please add a recording to this PR that shows:

  1. bun run dev running at http://localhost:3000
  2. The full working flow of your change (demonstrate the feature/fix end-to-end)
  3. Any tests passing — if your change touches logic with tests, show bun run lint and bunx tsc --noEmit completing without errors in the terminal

How to record:

  • macOS: Cmd + Shift + 5 → Record Selected Portion, or QuickTime Player
  • Windows: Win + G → Xbox Game Bar → Capture
  • Linux: OBS Studio, GNOME Screenshot, or kazam
  • Any OS: Loom (free, easy to share)

Once you have the recording, drag the file directly into a comment on this PR, or paste a Loom link. This is now a hard requirement — see CONTRIBUTING.md for full details.

Thanks for contributing to Reframe! 🎬

@TanviHanda

Copy link
Copy Markdown
Author

Hey @magic-peach
https://github.com/user-attachments/assets/0d73f794-75fe-4099-9747-3470c05cc63d

Added the screen recording showing the app running locally, the implemented flow working end-to-end, and the required UI elements with data-testid attributes.

@TanviHanda

Copy link
Copy Markdown
Author

Hi @magic-peach , I resolved the merge conflict and pushed the updated branch.

The remaining failed checks seem to be related to Vercel/Claude bot limits or external review/deployment issues. Please let me know if any code changes are needed from my side.

@magic-peach

Copy link
Copy Markdown
Owner

Hey @TanviHanda! This PR has merge conflicts with main. Please rebase to resolve them:

git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-lease

Once rebased and CI passes, this can be reviewed for merge.

@TanviHanda
TanviHanda force-pushed the add-testid-attributes branch from c7d1d26 to 3e37f88 Compare May 21, 2026 16:27
@github-actions github-actions Bot added the level:advanced Advanced level - 55 pts label May 21, 2026
@TanviHanda
TanviHanda force-pushed the add-testid-attributes branch 2 times, most recently from cd3c87f to a134363 Compare May 21, 2026 16:49
@TanviHanda
TanviHanda force-pushed the add-testid-attributes branch from a134363 to 174bbde Compare May 21, 2026 17:15
@magic-peach magic-peach added level:beginner Beginner level - 20 pts and removed level:advanced Advanced level - 55 pts level:beginner Beginner level - 20 pts type:bug Bug fix type:feature New feature type:docs Documentation type:design UI/UX design level:intermediate Intermediate level - 35 pts labels May 24, 2026
@magic-peach

Copy link
Copy Markdown
Owner

@TanviHanda Adding data-testid attributes to key UI elements is a useful addition for testing infrastructure! Please resolve the merge conflicts with main:

git fetch origin
git rebase origin/main
git push --force-with-lease

Also please fill in the PR description with what specific elements got data-testid attributes and which issue this relates to. Once CI (build/lint/typecheck) passes and the description is filled in, this can be merged!

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 24, 2026
@TanviHanda

TanviHanda commented May 24, 2026

Copy link
Copy Markdown
Author

Hi @magic-peach
Conflicts have been resolved and the PR description has been updated as requested.

The remaining failing check is Vercel deployment authorization, which requires maintainer/team permissions.

image

@magic-peach

Copy link
Copy Markdown
Owner

Hi @TanviHanda — thanks for this, and sorry for the wait.

I'd like to get this merged, but it replaces a cn() call with a template literal, which loses Tailwind class-conflict resolution.

To get it unblocked:

  1. restore the cn() wrapper on those className props

Could you take a look within the next 14 days? If I don't hear back by then I'll close it to keep the queue manageable — but you're very welcome to reopen it any time after that. Thanks again for contributing to Reframe 🙏

@magic-peach magic-peach added the status:changes-requested Maintainer asked for a specific fix label Aug 14, 2026
@TanviHanda

Copy link
Copy Markdown
Author

Hi @magic-peach
Okay, I’ll take a look and make the changes within 14 days. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts level:intermediate Intermediate level - 35 pts status:changes-requested Maintainer asked for a specific fix type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants