Skip to content

Commit 644ad1c

Browse files
committed
chore: demote some no longer urgent TODOs
1 parent bc1324d commit 644ad1c

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

magicblock-api/src/magic_validator.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ impl MagicValidator {
174174
config: MagicValidatorConfig,
175175
identity_keypair: Keypair,
176176
) -> ApiResult<Self> {
177-
// TODO(thlorenz): @@ this will need to be recreated on each start
177+
// TODO(thlorenz): this will need to be recreated on each start
178178
let token = CancellationToken::new();
179179

180180
let (geyser_manager, geyser_rpc_service) =
@@ -650,7 +650,7 @@ impl MagicValidator {
650650
}
651651

652652
async fn ensure_validator_funded_on_chain(&self) -> ApiResult<()> {
653-
// TODO: @@@ configurable?
653+
// TODO(thlorenz) make this configurable in the future
654654
const MIN_BALANCE_SOL: u64 = 5;
655655
// TODO: @@ duplicate code getting remote_rpc_config
656656
let accounts_config = try_convert_accounts_config(

magicblock-geyser-plugin/src/grpc.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ impl GrpcService {
144144
block_fail_action: ConfigBlockFailAction,
145145
) {
146146
const PROCESSED_MESSAGES_MAX: usize = 31;
147-
// TODO(thlorenz): @@@ This could become a bottleneck affecting latency
147+
// TODO(thlorenz): This could become a bottleneck affecting latency
148148
const PROCESSED_MESSAGES_SLEEP: Duration = Duration::from_millis(10);
149149

150150
let mut messages: BTreeMap<u64, SlotMessages> = Default::default();

magicblock-rpc/src/transaction.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ pub(crate) async fn send_transaction(
213213

214214
/// Verifies only the transaction signature and is used when sending a
215215
/// transaction to avoid the extra overhead of [sig_verify_transaction_and_check_precompiles]
216-
/// TODO(thlorenz): @@ sigverify takes upwards of 90µs which is 30%+ of
216+
/// TODO(thlorenz): sigverify takes upwards of 90µs which is 30%+ of
217217
/// the entire time it takes to execute a transaction.
218218
/// Therefore this an intermediate solution and we need to investigate verifying the
219219
/// wire_transaction instead (solana sigverify implementation is packet based)

0 commit comments

Comments
 (0)