Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Merging UpstreamPRs may not be a good idea #27

Closed
weex opened this issue Sep 15, 2021 · 1 comment
Closed

Problem: Merging UpstreamPRs may not be a good idea #27

weex opened this issue Sep 15, 2021 · 1 comment

Comments

@weex
Copy link
Member

weex commented Sep 15, 2021

Some concerns have been raised here, here and here about merging PRs from upstream. They are summarized here:

  • First, that such PRs might be work-in-progress and that by merging code before upstream maintainers, we would be taking on additional risk on a patch which may still receive comments and changes.
  • Second, if more changes are made and then the code is then merged upstream, we may have conflicts to resolve which might make merging not worth the extra maintenance.
  • Third, the author of the patch may be surprised that their code is used on a fork.

Are there other concerns that should be raised about this practice?

@weex
Copy link
Member Author

weex commented Dec 10, 2021

I think this can still be a valuable practice to bootstrap and doesn't seem to have caused any major problems, but at this point we have plenty of issues coming in from our community to keep us busy.

@weex weex closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant