Skip to content

Commit d315a8f

Browse files
localspookmahesh-attarde
authored andcommitted
[clang-tidy] Fix modernize-use-nullptr crash on 32-bit Windows (llvm#160023)
Fixes llvm#53778.
1 parent 25645d0 commit d315a8f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef<StringRef> NameList) {
5353
unless(hasImplicitDestinationType(
5454
qualType(matchers::matchesAnyListedTypeName(NameList)))));
5555

56-
auto IsOrHasDescendant = [](auto InnerMatcher) {
56+
auto IsOrHasDescendant = [](const auto &InnerMatcher) {
5757
return anyOf(InnerMatcher, hasDescendant(InnerMatcher));
5858
};
5959

clang-tools-extra/docs/ReleaseNotes.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,11 @@ Changes in existing checks
329329
<clang-tidy/checks/modernize/use-designated-initializers>` check to
330330
suggest using designated initializers for aliased aggregate types.
331331

332+
- Improved :doc:`modernize-use-nullptr
333+
<clang-tidy/checks/modernize/use-nullptr>` check by fixing a crash
334+
on Windows when the check was enabled with a 32-bit :program:`clang-tidy`
335+
binary.
336+
332337
- Improved :doc:`modernize-use-std-format
333338
<clang-tidy/checks/modernize/use-std-format>` check to correctly match
334339
when the format string is converted to a different type by an implicit

0 commit comments

Comments
 (0)