Skip to content

Commit f4a978b

Browse files
committed
Minor updates
1 parent 632304f commit f4a978b

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/test/java/io/mailtrap/api/bulkemails/BulkEmailsImplTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ void batchSend_ValidMailWithSubjectAndTextFromBase_SuccessResponse() {
199199
// Set up test data
200200
MailtrapBatchMail batchMail = MailtrapBatchMail.builder()
201201
.base(BatchEmailBase.builder().subject("Sample valid mail subject").text("Sample valid mail text").build())
202-
.requests(List.of(createValidTestMailForBatchWithNoSubjectAndText())).build();
202+
.requests(List.of(createTestMailForBatchWithNoSubjectAndText())).build();
203203

204204
// Perform call
205205
BatchSendResponse response = bulkEmails.batchSend(batchMail);
@@ -210,11 +210,11 @@ void batchSend_ValidMailWithSubjectAndTextFromBase_SuccessResponse() {
210210
}
211211

212212
@Test
213-
void batchSend_InvalidMailWithNoSubjectAndTextNoBase_SuccessResponse() {
213+
void batchSend_InvalidMailWithNoSubjectAndTextNoBase_ThrowsInvalidRequestBodyException() {
214214
// Set up test data
215215
MailtrapBatchMail batchMail = MailtrapBatchMail.builder()
216216
.base(BatchEmailBase.builder().text("Sample valid mail text").build())
217-
.requests(List.of(createValidTestMailForBatchWithNoSubjectAndText())).build();
217+
.requests(List.of(createTestMailForBatchWithNoSubjectAndText())).build();
218218

219219
// Assert
220220
InvalidRequestBodyException exception = assertThrows(InvalidRequestBodyException.class, () -> bulkEmails.batchSend(batchMail));

src/test/java/io/mailtrap/api/sendingemails/SendingEmailsImplTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ void batchSend_ValidMailWithSubjectAndTextFromBase_SuccessResponse() {
199199
// Set up test data
200200
MailtrapBatchMail batchMail = MailtrapBatchMail.builder()
201201
.base(BatchEmailBase.builder().subject("Sample valid mail subject").text("Sample valid mail text").build())
202-
.requests(List.of(createValidTestMailForBatchWithNoSubjectAndText())).build();
202+
.requests(List.of(createTestMailForBatchWithNoSubjectAndText())).build();
203203

204204
// Perform call
205205
BatchSendResponse response = sendApi.batchSend(batchMail);
@@ -210,11 +210,11 @@ void batchSend_ValidMailWithSubjectAndTextFromBase_SuccessResponse() {
210210
}
211211

212212
@Test
213-
void batchSend_InvalidMailWithNoSubjectAndTextNoBase_SuccessResponse() {
213+
void batchSend_InvalidMailWithNoSubjectAndTextNoBase_ThrowsInvalidRequestBodyException() {
214214
// Set up test data
215215
MailtrapBatchMail batchMail = MailtrapBatchMail.builder()
216216
.base(BatchEmailBase.builder().text("Sample valid mail text").build())
217-
.requests(List.of(createValidTestMailForBatchWithNoSubjectAndText())).build();
217+
.requests(List.of(createTestMailForBatchWithNoSubjectAndText())).build();
218218

219219
// Assert
220220
InvalidRequestBodyException exception = assertThrows(InvalidRequestBodyException.class, () -> sendApi.batchSend(batchMail));

src/test/java/io/mailtrap/api/testingemails/TestingEmailsImplTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ void batchSend_ValidMailWithSubjectAndTextFromBase_SuccessResponse() {
201201
// Set up test data
202202
MailtrapBatchMail batchMail = MailtrapBatchMail.builder()
203203
.base(BatchEmailBase.builder().subject("Sample valid mail subject").text("Sample valid mail text").build())
204-
.requests(List.of(createValidTestMailForBatchWithNoSubjectAndText())).build();
204+
.requests(List.of(createTestMailForBatchWithNoSubjectAndText())).build();
205205

206206
// Perform call
207207
BatchSendResponse response = testingApi.batchSend(batchMail, INBOX_ID);
@@ -212,11 +212,11 @@ void batchSend_ValidMailWithSubjectAndTextFromBase_SuccessResponse() {
212212
}
213213

214214
@Test
215-
void batchSend_InvalidMailWithNoSubjectAndTextNoBase_SuccessResponse() {
215+
void batchSend_InvalidMailWithNoSubjectAndTextNoBase_ThrowsInvalidRequestBodyException() {
216216
// Set up test data
217217
MailtrapBatchMail batchMail = MailtrapBatchMail.builder()
218218
.base(BatchEmailBase.builder().text("Sample valid mail text").build())
219-
.requests(List.of(createValidTestMailForBatchWithNoSubjectAndText())).build();
219+
.requests(List.of(createTestMailForBatchWithNoSubjectAndText())).build();
220220

221221
// Assert
222222
InvalidRequestBodyException exception = assertThrows(InvalidRequestBodyException.class, () -> testingApi.batchSend(batchMail, INBOX_ID));

src/test/java/io/mailtrap/testutils/BaseSendTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ protected MailtrapMail createValidTestMailForBatchWithNoSubject() {
6363
.build();
6464
}
6565

66-
protected MailtrapMail createValidTestMailForBatchWithNoSubjectAndText() {
66+
protected MailtrapMail createTestMailForBatchWithNoSubjectAndText() {
6767
Address from = getAddress("[email protected]", "John Doe");
6868
Address to = getAddress("[email protected]", "Jane Doe");
6969
EmailAttachment attachment = getAttachment();

0 commit comments

Comments
 (0)