Skip to content

Installing this package from Git using Yarn Berry v3.1.0 fails #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pichfl opened this issue Mar 17, 2022 · 5 comments
Closed

Installing this package from Git using Yarn Berry v3.1.0 fails #562

pichfl opened this issue Mar 17, 2022 · 5 comments
Labels
question Further information is requested

Comments

@pichfl
Copy link
Contributor

pichfl commented Mar 17, 2022

Unfortunately it seems this breaks installing this package from Git using Yarn Berry (at least v3.1.0 that I'm using) with nodeLinker: node-modules. Yarn says "Unsupported workflow", as it's seems like it doesn't understand pnpm lockfiles yet..

Originally posted by @bitwolfe in #477 (comment)

@pichfl
Copy link
Contributor Author

pichfl commented Mar 17, 2022

I haven't worked with Yarn Berry before and am a bit puzzled by this as I would expect an install from git to use the package.json 🤔

@bitwolfe could you provide a reproduction repository for this? We use pnpm in quite a few of our repositories and so far (and so do many other projects including much bigger ones such as Vue.js) and I haven't come across this issue yet.

@pichfl pichfl added the question Further information is requested label Mar 17, 2022
@bitwolfe
Copy link

It's very puzzling indeed! I would have expected it to just go by the package.json since no yarn.lock is present, not just give up because there is a pnpm-lock present...

I've set up a simple repo for reproduction: https://github.com/bitwolfe/epm-git-yarn-repro

@pichfl
Copy link
Contributor Author

pichfl commented Apr 12, 2022

Thanks for the reproduction, but I think this beyond the scope of this addon. We went with pnpm because it speeds up or CI and is what want to use for our packages going forward. A new version of promise modals which includes the latest fixes from master was released (with more fixes coming soon)

@bitwolfe
Copy link

That's fair. It does feel like it's either a bug in Yarn or some kind of configuration issue. Either way it behaves very strangely.

With there being a new version out which includes the fixes I needed, I no longer need to install directly from the git repo and can let this go for now.

@pichfl pichfl closed this as completed Apr 22, 2022
@flying-sheep
Copy link

See yarnpkg/berry#3169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants