Skip to content

Focus is immediately applied on open, may cause trouble! #755

Open
@nickschot

Description

@nickschot

Currently we immediately apply the focus-trap even if an animation is still about to happen. This may cause problems if something like an ember-tether is rendered inside the modal as the modal might still be moving.

This could be solved by utilizing the checkCanFocusTrap hook: https://github.com/focus-trap/focus-trap#createoptions . We can pass it a promise that resolves once the animation is complete.

We might want similar behaviour when closing the modal

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions