Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unit tests for functions in crash_similarity.py, utils.py and bugzilla.py #11

Open
marco-c opened this issue Mar 16, 2017 · 4 comments

Comments

@marco-c
Copy link
Owner

marco-c commented Mar 16, 2017

We don't need to write all tests at the same time, there can be multiple PRs where each one adds some tests.

@marco-c marco-c changed the title Add some unit tests for functions in crash_similarity.py Add some unit tests for functions in crash_similarity.py and utils.py Mar 17, 2017
@marco-c marco-c changed the title Add some unit tests for functions in crash_similarity.py and utils.py Add some unit tests for functions in crash_similarity.py, utils.py and bugzilla.py Mar 20, 2017
@mansimarkaur
Copy link
Contributor

I'd like to work on this.

@marco-c
Copy link
Owner Author

marco-c commented Mar 21, 2017

Thanks! You could start with the bugzilla.py module, which is the simplest one.

@mansimarkaur
Copy link
Contributor

How exactly should I be verifying the response for the signatures that returned after a call to get_signatures_from_bug?

@marco-c
Copy link
Owner Author

marco-c commented Mar 22, 2017

Pick a couple of bugs from bugzilla that have crash signatures, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1333486, and verify that the signatures returned by get_signatures_from_bug are the same that you're seeing on Bugzilla ( @0x0 | idmcchandler7_64.dll@0x238bf, @0x0 | idmcchandler7_64.dll@0x1feaf, @0x0 | idmcchandler7_64.dll@0x238bf, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants