Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 🐾 CSS help wanted! We need to upgrade our footer #301

Closed
6 tasks
LowLifeArcade opened this issue Oct 23, 2021 · 5 comments · Fixed by #303
Closed
6 tasks

✨ 🐾 CSS help wanted! We need to upgrade our footer #301

LowLifeArcade opened this issue Oct 23, 2021 · 5 comments · Fixed by #303
Assignees
Labels
css design hacktoberfest for hacktober hacktoberfest-accepted idea Any lightbulb over your head about what could make this better

Comments

@LowLifeArcade
Copy link
Collaborator

LowLifeArcade commented Oct 23, 2021

What should we change and why?

It's time for an upgrade!

If you feel comfortable with css and want to use your chops to develop from a (loose) design, please join us! Using our CSS guidelines you can expect this to be a back and forth after you submit a PR to get everything right.

The bounding boxes are best guesses for flex in css. If you can create a better way, feel free to implement your own solution so long as it is responsive and follows the layout.

Padding and margin are whatever makes the layout work best so long as other measurements are met.

The footer should be

  • Responsive
  • Two toned using the colors on the diagram
  • Have a squiggly css thing separating the two tones (think water)
  • following layout as closely as possible
  • following our CSS guidelines
  • leave enough room for adding more links in the programs section

Footer desktop and mobile

footer

@LowLifeArcade LowLifeArcade added idea Any lightbulb over your head about what could make this better hacktoberfest-accepted hacktoberfest for hacktober css design labels Oct 23, 2021
@akshitarora921
Copy link
Contributor

@LowLifeArcade Can you assign this to me.

@LowLifeArcade
Copy link
Collaborator Author

For sure @akshitarora921 🦖 ✨

@syauqy
Copy link

syauqy commented Oct 24, 2021

Hi @LowLifeArcade,
If you have any other ideas on the front end, I'd like to help to implement them.

@akshitarora921
Copy link
Contributor

akshitarora921 commented Oct 25, 2021

Hi @syauqy,
If you know how to write tests, can you help me with issue #162?

@LowLifeArcade
Copy link
Collaborator Author

For sure @syauqy. Thank you. I have some things coming, I'll keep you in mind. If you do have experience with tests, feel free to help with @akshitarora921 and #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css design hacktoberfest for hacktober hacktoberfest-accepted idea Any lightbulb over your head about what could make this better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants