-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterate on card design #96
Comments
I would like to work on this issue |
Hi @sre-harine! I just assigned related issue #66 to @Harshak30 which has some overlap with this, which could create merge conflicts. Let's give him a chance to submit his work first. Once his changes are in, we can assign you this. In the meantime see if there are any other issues that interest you. |
I think they got busy. @sre-harine this is yours to work on if you'd still like! Otherwise just unassign yourself. |
I will takeover this work |
As you have mentioned, I tried putting the card images above the card text, and made the card text dark. It improves readability and is in sync with the site background, but the card size became big. Is that okay? @audreyfeldroy |
@sre-harine The best way for review is to create a Pull Request, that way the Vercel bot will automatically-generate a preview that we can see in addition to providing easy viewing of your changes. While viewing your changes we can then see what might be causing problems and provide you with the best possible feedback and contribution experience. 😃 |
Now that I've updated the site background to white to better accommodate the brightness of the MHF logo, the cards that once looked really amazing as part of a beautiful earlier iteration by @suveshmoza now appear a bit dark.
This issue is open to anyone who wants to experiment with it: just add yourself under Assignees to claim this.
The text was updated successfully, but these errors were encountered: