OAuth's deParam has a bug with array parameters

[thalmicg]

i'm a new dev so i don't even know how to properly fix someone else's branch, but there is a bug in deParam method of OAuth

The object loop is overwriting values even when they already exist. If necessary it should convert this value to an array and add to the array

[mark-keaton]

Hey @thalmicg,

I haven't had a chance to look yet.

Do you mean here in this function:
https://github.com/mark-keaton/oauth-netsuite/blob/master/oauth.js#L177

And if you ever want to submit a Pull Request to fix issues, they're always welcome.

Thanks,
Mark

[thalmicg]

Hi back, Correct.. line 187 <https://github.com/mark-keaton/oauth-netsuite/blob/master/oauth.js#L187> need something like this <https://stackoverflow.com/a/1988361> I'm new to git and this whole world of pull requests, etc. P.S. if you know anyone who is willing to teach (for a fee) someone how to get their daily development tasks into a developer's workflow (source control, testing, etc) then I'd be very interested. For a fee is understandable.

…

On 1 May 2018 at 14:31, mark-keaton ***@***.***> wrote: Hey @thalmicg <https://github.com/thalmicg>, I haven't had a chance to look yet. Do you mean here in this function: https://github.com/mark-keaton/oauth-netsuite/blob/master/oauth.js#L177 And if you ever want to submit a Pull Request to fix issues, they're always welcome. Thanks, Mark — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhowMSPV-jE-xuT9K6tiydMAO8vSFdCTks5tuKn4gaJpZM4TtS5Z> .

-- Gerald

-- ----CONFIDENTIALITY NOTICE:  This communication, and any attachments thereto, is confidential and intended solely for use by the recipient(s) named above.