🎨 [#235] improve the way we validate phonenumbers #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonnyBA
requested changes
Nov 20, 2024
bart-maykin
force-pushed
the
feature/235-better-phonenumber-validator
branch
from
5fb8a86 to
b4fa414
Compare
stevenbal
reviewed
Nov 21, 2024
| @@ -74,25 +74,37 @@ def test_validate_postal_code(self): | |||
| self.assertIsNone(validate_postal_code("1015 cJ")) | |||
|
|
|||
| def test_validate_phone_number(self): | |||
| valid_phone_numbers = [ | |||
| "+31612345678", | |||
There was a problem hiding this comment.
Would/should something like 0612345678 still be valid?
There was a problem hiding this comment.
Yes, and I added it to the test to proof it.
|
@stevenbal I replaced the |
stevenbal
approved these changes
Nov 21, 2024
SonnyBA
reviewed
Nov 21, 2024
…tor, and added phonenumber validation to it.
bart-maykin
force-pushed
the
feature/235-better-phonenumber-validator
branch
from
ab31581 to
34b1ea4
Compare
SonnyBA
requested changes
Nov 22, 2024
| @@ -123,10 +123,10 @@ def test_digitaal_adres_inline(self): | |||
| @disable_admin_mfa() | |||
| class DigitaalAdresAdminTests(WebTest): | |||
| @tag("gh-234") | |||
| def test_email_validation(self): | |||
| def test_soort_digitaal_adres_validation(self): | |||
There was a problem hiding this comment.
@bart-maykin could you split the three subtests into their own tests?
SonnyBA
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Changes
Improved the way we validate phonenumbers with the phonenumbers library