Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter parameter to filter klantcontacten on a betrokkene's partij #256

Closed
swrichards opened this issue Oct 2, 2024 · 0 comments · Fixed by #285
Closed

Add a filter parameter to filter klantcontacten on a betrokkene's partij #256

swrichards opened this issue Oct 2, 2024 · 0 comments · Fixed by #285
Assignees
Labels
enhancement New feature or request owner: dimpact

Comments

@swrichards
Copy link
Contributor

Thema / Theme

Klantinteracties API

Omschrijving / Description

In addition to hadBetrokkene__uuid, and hadBetrokkene__url, add a new parameter hadBetrokkene__wasPartij__uuid to filter the klantcontacten list with reference to a specific Partij.

Toegevoegde waarde / Added value

"Give me all klantcontacten for a known Partij" is a common and obvious use-case, but currently has no easy path. You can either:

  1. Fetch all betrokkenen filtering by wasPartij__uuid, and then use the hadKlantcontact field to build up a list of klantcontacten. However, you then still have to fetch each klantcontact individually, which will require a lot of individual requests in order to build up the full list, which is undesirable.
  2. Fetch all klantcontacten with an expanded hadBetrokkenen.wasPartij and do the filtering by partij client-side. This is also undesirable, as you have to fetch the whole collection of klantcontacten to be sure all records for a particular Partij have been fetched.

Aanvullende opmerkingen / Additional context

No response

@swrichards swrichards added enhancement New feature or request triage labels Oct 2, 2024
bart-maykin added a commit that referenced this issue Nov 15, 2024
@alextreme alextreme moved this from Triage to Todo in Data en API fundament Nov 19, 2024
bart-maykin added a commit that referenced this issue Nov 19, 2024
bart-maykin added a commit that referenced this issue Nov 19, 2024
bart-maykin added a commit that referenced this issue Nov 21, 2024
bart-maykin added a commit that referenced this issue Nov 21, 2024
…ri, decided to use this not so elegant way to set this data because using extend_schema_field on the URLViewFilter would remove the help_texts of the filters. The other solutions were to use the extend_view to set every parameter for the views we use this fields by hand, to define one generic description or to let the queryparam type be wrongly defined and give a warning in the help_text.
bart-maykin added a commit that referenced this issue Nov 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Data en API fundament Nov 26, 2024
SonnyBA added a commit that referenced this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request owner: dimpact
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants