-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a filter parameter to filter klantcontacten on a betrokkene's partij #256
Labels
Comments
bart-maykin
added a commit
that referenced
this issue
Nov 21, 2024
bart-maykin
added a commit
that referenced
this issue
Nov 21, 2024
bart-maykin
added a commit
that referenced
this issue
Nov 21, 2024
bart-maykin
added a commit
that referenced
this issue
Nov 21, 2024
bart-maykin
added a commit
that referenced
this issue
Nov 21, 2024
…ri, decided to use this not so elegant way to set this data because using extend_schema_field on the URLViewFilter would remove the help_texts of the filters. The other solutions were to use the extend_view to set every parameter for the views we use this fields by hand, to define one generic description or to let the queryparam type be wrongly defined and give a warning in the help_text.
bart-maykin
added a commit
that referenced
this issue
Nov 22, 2024
SonnyBA
added a commit
that referenced
this issue
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thema / Theme
Klantinteracties API
Omschrijving / Description
In addition to
hadBetrokkene__uuid
, andhadBetrokkene__url
, add a new parameterhadBetrokkene__wasPartij__uuid
to filter theklantcontacten
list with reference to a specificPartij
.Toegevoegde waarde / Added value
"Give me all
klantcontacten
for a knownPartij
" is a common and obvious use-case, but currently has no easy path. You can either:betrokkenen
filtering bywasPartij__uuid
, and then use thehadKlantcontact
field to build up a list ofklantcontacten
. However, you then still have to fetch eachklantcontact
individually, which will require a lot of individual requests in order to build up the full list, which is undesirable.klantcontacten
with an expandedhadBetrokkenen.wasPartij
and do the filtering by partij client-side. This is also undesirable, as you have to fetch the whole collection ofklantcontacten
to be sure all records for a particularPartij
have been fetched.Aanvullende opmerkingen / Additional context
No response
The text was updated successfully, but these errors were encountered: