Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET digitaleadressen returns error on query parameter adres__icontains #265

Closed
sytskevanhasselt opened this issue Oct 15, 2024 · 0 comments · Fixed by #289
Closed

GET digitaleadressen returns error on query parameter adres__icontains #265

sytskevanhasselt opened this issue Oct 15, 2024 · 0 comments · Fixed by #289
Assignees
@danielmursa-dev
Labels
bug Something isn't working owner: dimpact

Comments

@sytskevanhasselt
Copy link

sytskevanhasselt commented Oct 15, 2024 •
edited
Loading

Product versie / Product version

2.2.0

Omschrijf het probleem / Describe the bug

The openapi.yml of version 2.2.0 lists the following query parameter for the GET on /digitaleadressen:
adres__icontains

However, when we use this query parameter, the api returns a FieldError:

FieldError at /klantinteracties/api/v1/digitaleadressen
Unsupported lookup 'icontains' for CharField or join on the field not permitted, perhaps you meant icontains or contains?

Stappen om te reproduceren / Steps to reproduce

  1. From Postman, run the following GET: https://www.mijnopenklant.nl/klantinteracties/api/v1/digitaleadressen?adres__icontains=0618644222

Verwacht gedrag / Expected behavior

I would expect a valid response with no results (or: in our situation 4 results)
@sytskevanhasselt sytskevanhasselt added bug Something isn't working triage labels Oct 15, 2024
danielmursa-dev added a commit that referenced this issue Nov 25, 2024
@danielmursa-dev
[#265] Fix adres__icontains + tests
c909918
@danielmursa-dev danielmursa-dev mentioned this issue Nov 25, 2024
Merged
danielmursa-dev added a commit that referenced this issue Nov 25, 2024
@danielmursa-dev
[#265] Fix adres__icontains + tests
3d0ec42 
[#265] Merge
danielmursa-dev added a commit that referenced this issue Nov 25, 2024
@danielmursa-dev
[#265] Fix adres__icontains + tests
f62e1d0 
[#265] Merge
danielmursa-dev added a commit that referenced this issue Nov 29, 2024
@danielmursa-dev
[#265] Fix adres__icontains + tests
0567d71 
[#265] Merge

[#65] Fix tests after merge
stevenbal added a commit that referenced this issue Nov 29, 2024
@stevenbal
Merge pull request #289 from maykinmedia/265-fix-digitaleadressen-que…
bedc8fd 
…ry-parameter

[#265] Fix adres__icontains + tests
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmursa-dev danielmursa-dev

Labels
bug Something isn't working owner: dimpact
Projects
Data en API fundament
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#265] Fix adres__icontains + tests maykinmedia/open-klant
3 participants
@alextreme @sytskevanhasselt @danielmursa-dev