Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landcodes, waarom niet aanhouden van ISO 3166? #311

Closed
alextreme opened this issue Dec 20, 2024 · 1 comment · Fixed by #317
Closed

Landcodes, waarom niet aanhouden van ISO 3166? #311

alextreme opened this issue Dec 20, 2024 · 1 comment · Fixed by #317
Assignees
@danielmursa-dev
Labels
approved enhancement New feature or request owner: den-haag
Milestone
Release 2.6.0

Comments

@alextreme
Copy link
Member

Thema / Theme

Klantinteracties API

Omschrijving / Description

Bij een Partij is nu een 4-teken landcode veld opgenomen voor buitenlandse adressen

Waarom wordt hier niet de ISO 3166 standaard aangehouden? 2 tekens en validatie hierop zou voldoende moeten zijn in plaats van een eigen landenlijst aanhouden

Toegevoegde waarde / Added value

No response

Aanvullende opmerkingen / Additional context

No response
@joeribekker joeribekker removed the triage label Jan 6, 2025
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Jan 6, 2025
@joeribekker
Copy link
Member

Approved by Alex-proxy due to prio.

@danielmursa-dev danielmursa-dev moved this from Todo to In Progress in Data en API fundament Jan 9, 2025
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Add country dict
76835fe
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Update models + migrations
b343f08
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Create Tests
32f6164
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Fix Tests
e442bb0
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Upgrade migration
29fba52
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Test migration
bdfe9eb
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Isort and flake
48ae0ff
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Upgrade migration
88d050a
danielmursa-dev added a commit that referenced this issue Jan 10, 2025
@danielmursa-dev
[#311] Fix naming
31fd0f7
@danielmursa-dev danielmursa-dev mentioned this issue Jan 10, 2025
Merged
@danielmursa-dev danielmursa-dev moved this from In Progress to Implemented in Data en API fundament Jan 10, 2025
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Remove iso_code key from COUNTRIES_DICT
4f2ce84
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Add source comment for COUNTRIES_DICT
d3301d3
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Install django-localflavor
69494f8
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Fix validate_country
8ec3a92
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Update COUNTRIES_DICT
a079ee6
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Update nl_code_to_iso_code_country_converter
f9f528b
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Update migrations
cbc1ff9
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Update migrations methods
de77c53
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Improve tests
071e565
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] New tests
4f4ff00
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Isort
f71072a
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Fix merge conflicts
7ed53f9
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Fix migrations
9bfbdf5
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Fix tests
6293a3c
danielmursa-dev added a commit that referenced this issue Jan 27, 2025
@danielmursa-dev
[#311] Fix schema
cf4ee5d
danielmursa-dev added a commit that referenced this issue Jan 30, 2025
@danielmursa-dev
[#311] Update messages
b73ffa7
danielmursa-dev added a commit that referenced this issue Jan 30, 2025
@danielmursa-dev
[#311] Add country dict
ea34352 
[#311] Update models + migrations

[#311] Create Tests
danielmursa-dev added a commit that referenced this issue Jan 30, 2025
@danielmursa-dev
[#311] Fix merge
6b6a99a
danielmursa-dev added a commit that referenced this issue Jan 30, 2025
@danielmursa-dev
[#311] Add country dict
e92eae5 
[#311] Update models + migrations

[#311] Create Tests
danielmursa-dev added a commit that referenced this issue Jan 30, 2025
@danielmursa-dev
[#311] Add country dict
5639fa0 
[#311] Update models + migrations

[#311] Create Tests

Schema
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Jan 30, 2025
@danielmursa-dev danielmursa-dev added this to the Release 2.6.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmursa-dev danielmursa-dev

Labels
approved enhancement New feature or request owner: den-haag
Projects
Data en API fundament
Archived in project
Milestone
Release 2.6.0
Development

Successfully merging a pull request may close this issue.

Feature/311 validation country code maykinmedia/open-klant
3 participants
@joeribekker @alextreme @danielmursa-dev