-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/311 validation country code #317
Conversation
...nt/components/klantinteracties/migrations/0024_alter_betrokkene_bezoekadres_land_and_more.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I think, so this is a soft approve
I think you should test bad and empty country codes in the migration, just to make sure all cases are covered.
...nt/components/klantinteracties/migrations/0024_alter_betrokkene_bezoekadres_land_and_more.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small stuff, looks good otherwise.
Once it is approved, could you rebase or squash the commits?
...tactgegevens/migrations/0004_alter_organisatie_adres_land_alter_organisatie_land_and_more.py
Outdated
Show resolved
Hide resolved
...tactgegevens/migrations/0004_alter_organisatie_adres_land_alter_organisatie_land_and_more.py
Outdated
Show resolved
Hide resolved
...nt/components/klantinteracties/migrations/0026_alter_betrokkene_bezoekadres_land_and_more.py
Show resolved
Hide resolved
6b6a99a
to
e92eae5
Compare
e92eae5
to
5639fa0
Compare
Fixes #311
land
fieldsvalidate_country
nl_code_to_iso_code_country_converter
(ISO 3166)Created COUNTRIES_DICT in
openklant/utils/constants.py
, from https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://publicaties.rvig.nl/dsresource%3Fobjectid%3D7a15a0d7-7282-403c-92a8-397f0da23d44%26type%3Dpdf&ved=2ahUKEwiK6Z6ymeiKAxUT2AIHHXInHC8QFnoECBoQAQ&usg=AOvVaw1Y5bNvX9xsQjY0ihbxKPfJScript: