Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔖 [#318] Release 2.5.0 #319

Merged
merged 2 commits into from
Jan 28, 2025
Merged

🔖 [#318] Release 2.5.0 #319

merged 2 commits into from
Jan 28, 2025

Conversation

stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented Jan 16, 2025 •
edited
Loading

Closes #318

@stevenbal stevenbal marked this pull request as draft January 16, 2025 09:12
@stevenbal stevenbal force-pushed the release/2.5.0 branch 4 times, most recently from 67ace20 to 517ca8c Compare January 16, 2025 09:45
@stevenbal stevenbal marked this pull request as ready for review January 16, 2025 09:46
@stevenbal stevenbal requested review from Coperh, joeribekker and SonnyBA and removed request for Coperh and joeribekker January 16, 2025 09:46
SonnyBA
SonnyBA approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@SonnyBA SonnyBA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment about the zgw-consumers upgrade entry but looks good overall 👍

Coperh
Coperh approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Why does open-klant 2.4.0 not have a merge commit? I was looking for it and it has none

@alextreme
Copy link
Member

@joeribekker please give final approval for OK2.5

@stevenbal
Copy link
Collaborator Author

Why does open-klant 2.4.0 not have a merge commit? I was looking for it and it has none

@Coperh I'm not sure either. @SonnyBA do you know why there is no merge commit for 2.4.0? 83f9aec

@SonnyBA
Copy link
Contributor

SonnyBA commented Jan 22, 2025

Why does open-klant 2.4.0 not have a merge commit? I was looking for it and it has none

@Coperh I'm not sure either. @SonnyBA do you know why there is no merge commit for 2.4.0? 83f9aec

I assume a "fast-forward" happened for that release, see https://stackoverflow.com/a/29673993. In the commit message you can see the Github generated commit (and that there was a PR made for the changes).

stevenbal
stevenbal commented Jan 27, 2025
View reviewed changes
@stevenbal stevenbal merged commit 68d21b0 into master Jan 28, 2025
20 checks passed
@stevenbal stevenbal deleted the release/2.5.0 branch January 28, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeribekker joeribekker joeribekker approved these changes

@Coperh Coperh Coperh approved these changes

@SonnyBA SonnyBA SonnyBA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open Klant release 2.5
5 participants
@stevenbal @alextreme @SonnyBA @joeribekker @Coperh