New component: Converter

[mbilbille]

Here is an interesting feature which could be added to JpnForPhp ; a new component for Japanese units conversion.

So far, here is what I have in mind:

• year 昭和59 = 1984
• number 二万/２万 = 20000
• measure (http://en.wikipedia.org/wiki/Japanese_units_of_measurement)

Feel free to add new units to this list :)

[mbilbille]

Thanks to @Akeru's work PR #47, we've a working version of the Converter component to release on 0.6 :)

On 0.7 we should complete this component with reverse number conversion (ie: Japanese format into Arabic/Western numeral). Would be nice to have Years conversion as well.

[Akeru]

Year conversion in PR #48

[mbilbille]

Nice, we can include that within the 0.6! Thanks @Akeru

[mbilbille]

Will try to spare some time to rearrange Converter.php into smaller files (.php and .yml files) as we did with Transliterator.php

[mbilbille]

Btw unit tests are broken on a 32-bit system.

1) JpnForPhp\Tests\Converter\ConverterTest::testConversionToJapaneseNumeral1050919092985
Undefined offset: 0

E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:467
E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:450
E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:455
E:\tmp\jpnforphp\tests\JpnForPhp\Converter\ConverterTest.php:82
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:176
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:129

2) JpnForPhp\Tests\Converter\ConverterTest::testConversionToJapaneseNumeral10100100100101
Undefined offset: 0

E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:467
E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:450
E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:455
E:\tmp\jpnforphp\tests\JpnForPhp\Converter\ConverterTest.php:88
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:176
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:129

3) JpnForPhp\Tests\Converter\ConverterTest::testConversionToJapaneseNumeralReading1000000000000
array_key_exists(): The first argument should be either a string or an integer

E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:449
E:\tmp\jpnforphp\tests\JpnForPhp\Converter\ConverterTest.php:124
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:176
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:129

4) JpnForPhp\Tests\Converter\ConverterTest::testConversionToJapaneseNumeralReading1050919092985
array_key_exists(): The first argument should be either a string or an integer

E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:449
E:\tmp\jpnforphp\tests\JpnForPhp\Converter\ConverterTest.php:130
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:176
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:129

5) JpnForPhp\Tests\Converter\ConverterTest::testConversionToWesternYearKanjiMeiji33
Exception: Year 明治33 is invalid

E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:537
E:\tmp\jpnforphp\tests\JpnForPhp\Converter\ConverterTest.php:203
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:176
E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:129

FAILURES!
Tests: 248, Assertions: 1940, Errors: 5.```

[Akeru]

Yes, it is a known issue where integers are auto promoted to float when overflowing. Using them as array keys/indices will cause these errors. Not sure there is something that can be done about this.

[mbilbille]

Yes that was my understanding too.

JpnForPhp\Tests\Converter\ConverterTest::testConversionToWesternYearKanjiMeiji33

Didn't have time to investigate further, don't know this one on date conversion fails for the same reason.

[mbilbille]

Fixed above issues with :
3ddfc86
3dcbee8
7b943f9