Getting a segfault with accelerate built on OSX Intel

[ChrisBarker-NOAA]

NOTE:

I'm trying to make a conda-forge package of OpenGL_accelerate. But so far, I can't get it to even build locally the usual way on My Intel Mac :-(

Using Cython 0.29.37

(Cython 3 fails -- see:

Same result with Python 3.9 -- 3.12 :-(

Running the full tests, I get a segfault. It may be from:

test_arraydatatypeaccel.py, line 28 in test_arraySize

I few notes -- if I run the tests without installing numpy, then they pass, other than the ones that are skipped .. so it seems to be numpy related.

If I run numpy 1.26, I get the segfault.

If I run numpy 2, I get a datatype missmatch error ...

(Though I'm pretty sure I built it with numpy 2 ...)

Also -- using the conda-forge "build_locally" script, it builds for multiple versions of Python, and should keep numpy straight, and they are all getting the segfault.

I'm going to dig more, but if anyone's seen this, let me know!

Here's the full dump:

test_arraydatatypeaccel.py .Fatal Python error: Segmentation fault

Current thread 0x00007ff854e9e300 (most recent call first):
  File "/Users/chris.barker/Hazmat/CondaForge/pyopengl_accelerate-3.1.9/tests/test_arraydatatypeaccel.py", line 28 in test_arraySize
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/unittest/case.py", line 549 in _callTestMethod
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/unittest/case.py", line 591 in run
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/unittest/case.py", line 650 in __call__
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/unittest.py", line 351 in runtest
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/runner.py", line 178 in pytest_runtest_call
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_callers.py", line 121 in _multicall
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_hooks.py", line 512 in __call__
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/runner.py", line 246 in <lambda>
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/runner.py", line 344 in from_call
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/runner.py", line 245 in call_and_report
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/runner.py", line 136 in runtestprotocol
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/runner.py", line 117 in pytest_runtest_protocol
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_callers.py", line 121 in _multicall
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_hooks.py", line 512 in __call__
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/main.py", line 367 in pytest_runtestloop
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_callers.py", line 121 in _multicall
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_hooks.py", line 512 in __call__
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/main.py", line 343 in _main
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/main.py", line 289 in wrap_session
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/main.py", line 336 in pytest_cmdline_main
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_callers.py", line 121 in _multicall
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/pluggy/_hooks.py", line 512 in __call__
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/config/__init__.py", line 175 in main
  File "/Users/chris.barker/miniforge3/envs/junk/lib/python3.10/site-packages/_pytest/config/__init__.py", line 201 in console_main
  File "/Users/chris.barker/miniforge3/envs/junk/bin/pytest", line 10 in <module>

Extension modules: OpenGL_accelerate.errorchecker, OpenGL_accelerate.wrapper, OpenGL_accelerate.formathandler, OpenGL_accelerate.arraydatatype, OpenGL_accelerate.vbo, OpenGL_accelerate.latebind, numpy.core._multiarray_umath, numpy.core._multiarray_tests, numpy.linalg._umath_linalg, numpy.fft._pocketfft_internal, numpy.random._common, numpy.random.bit_generator, numpy.random._bounded_integers, numpy.random._mt19937, numpy.random.mtrand, numpy.random._philox, numpy.random._pcg64, numpy.random._sfc64, numpy.random._generator, OpenGL_accelerate.numpy_formathandler (total: 20)
Segmentation fault: 11

[ChrisBarker-NOAA]

OK -- I think I solved it -- building with Cython < 3 let the long work, but maybe it was using the wrong long -- i.e. the old python2 long int, rather than a C long.

Adding:

from ctypes import c_long as long

As suggested in: #146

Allows it to build with Cython 3+ -- and the result works, passing all the tests, with no segfaults.

So I'll close this for now -- but let's get #146 applied!

[ChrisBarker-NOAA]

NOTE: wish I'd noticed this earlier:

richardssam/OpenRV@7dca78f

[ChrisBarker-NOAA]

NOTE: I've got the recipe building on conda-forge -- all good :-) Hopefully it will be available soon.

But it did require the patch.