es6 style #6
Open
es6 style #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is indeed a critical upgrade -- however what do you think about the loss in clarity and debuggability that comes from removing the explicitly named function? Also, ES6 updates will necessitate upgrading the .travis.yml to run with a ... slightly newer version of Node. Maybe we should try this with a really old LTS, like version 4, just to be on the safe side? Backward compatibility is of vital importance for such an important fundamental part of the JavaScript ecosystem. |
maxime-fleury
suggested changes
Dec 19, 2024
maxime-fleury
left a comment
maxime-fleury
left a comment
There was a problem hiding this comment.
Still takes too much space, can you make it shorter ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.