Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Temporal] Explicitly mention 7 when talking about days in a week, rather than leaving it as an assumed 'default knowledge' #38000

Closed
0xdevalias opened this issue Feb 6, 2025 · 3 comments · Fixed by #38006
Labels
accepting PR Feel free to open a PR to resolve this issue Content:JS JavaScript docs

Comments

@0xdevalias
Copy link
Contributor

0xdevalias commented Feb 6, 2025

MDN URL

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal#calendars

What specific section or headline is this issue about?

Calendars

What information was incorrect, unhelpful, or incomplete?

Another minor 'feels a little weird' tweak:

The concept of a "week" is not connected with any astronomical event, but is a cultural construct. Therefore, weeks can have 4, 5, 6, 8, or more days, or not even a fixed number of days. To get the specific number of days of the week of a date, use the date's daysInWeek.

I assume that 7 was left out of here because it is the assumed default/most common, but the way this is worded currently, it felt strange to me that 7 wasn't mentioned at all. If this default assumption was made more explicit, I think that would improve the feel of this paragraph.

What did you expect to see?

A potential rewording:

The concept of a "week" is not connected with any astronomical event, but is a cultural construct. While the most common length is 7 days, weeks can also have 4, 5, 6, 8, or more days — or even lack a fixed number of days altogether.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

@Josh-Cena FYI RE: this request for review

Though in light of this:

PRs are welcome :)

Originally posted by @Josh-Cena in #37996

I will probably just also knock up a PR for this shortly, unless I hear any strong objections to it prior.

MDN metadata

Page report details
@0xdevalias 0xdevalias added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 6, 2025
@github-actions github-actions bot added the Content:JS JavaScript docs label Feb 6, 2025
@0xdevalias 0xdevalias changed the title [Temporal] [Temporal] Explicitly mention 7 when talking about days in a week, rather than leaving it as an assumed 'default knowledge' Feb 6, 2025
@Josh-Cena
Copy link
Member

Yes, feel free to post PRs directly instead of issues, as those are more likely to be addressed quickly.

The purpose of this section is more to clear up some misassumptions about calendar information, so "you already know what Gregorian looks like" is implied.

@Josh-Cena Josh-Cena added accepting PR Feel free to open a PR to resolve this issue and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 6, 2025
@0xdevalias
Copy link
Contributor Author

so "you already know what Gregorian looks like" is implied.

As a westerner, makes sense and is my default for sure. But my feel was that not everyone reading this may have the same defaults as me, therefore it would be better to be explicit than to rely on assuming cultural norms (doubly so in a section talking about how cultural norms differ)

@0xdevalias
Copy link
Contributor Author

0xdevalias commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR Feel free to open a PR to resolve this issue Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants