Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing example on grid layout learn guide page #38167

Open
tbaiense opened this issue Feb 15, 2025 · 2 comments
Open

Missing example on grid layout learn guide page #38167

tbaiense opened this issue Feb 15, 2025 · 2 comments
Labels
Content:Learn Learning area docs

Comments

@tbaiense
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/CSS_layout/Grids

What specific section or headline is this issue about?

Flexible grids with the fr unit

What information was incorrect, unhelpful, or incomplete?

I think there's a missing example below the 3th paragraph on section "Flexible grids with the fr unit", where is says

You now have flexible tracks. The fr unit distributes space proportionally. You can specify different positive values for your tracks like so:

What did you expect to see?

A CSS snippet or image with an example of different positive values for each track, as the paragraph says.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@tbaiense tbaiense added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 15, 2025
@github-actions github-actions bot added the Content:Learn Learning area docs label Feb 15, 2025
@Josh-Cena
Copy link
Member

@dletorey @bsmth in #37525 made this example code all hidden and there's no EmbedLiveSample. Is the intention to just make a live sample here, or do we also need to unhide the code?

@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 16, 2025
@bsmth
Copy link
Member

bsmth commented Feb 17, 2025

Thanks, Josh. That's another structural leftover. We should fix by combining the prose like this:

You now have flexible tracks. The fr unit distributes space proportionally. You can specify different positive values for your tracks like so:

code…

Now change your track listing to the following definition, creating one 2fr two 1fr tracks:

You now have flexible tracks. The fr unit distributes space proportionally, so you can specify different positive values for your tracks. Change your track listing to the following definition, creating one 2fr two 1fr tracks:

code…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs
Projects
None yet
Development

No branches or pull requests

3 participants