Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing description gracefully #2

Open
meeDamian opened this issue Sep 2, 2019 · 0 comments
Open

Handle missing description gracefully #2

meeDamian opened this issue Sep 2, 2019 · 0 comments

Comments

@meeDamian
Copy link
Owner

Currently when description sync is on, and there's no description, error happens. no good.
ndeet added a commit to ndeet/sync-readme that referenced this issue Nov 18, 2019
@ndeet
Fix GH API path to include GH user
507e114 
The API call seems to miss the GH user and returns always `null` for me when running in terminal. 

Note: I have no idea what that `:-` does in line 34 + 35, can you enlighten me? 

For the API call on GH it should use the original GH user + repo name otherwise the to lowercased values (for DockerHub) will fail in this case? 

Maybe this fixes meeDamian#2 also. I had `description: true` and actually a description on my repo but it failed.
@ndeet ndeet mentioned this issue Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH API path to include GH user ndeet/sync-readme
1 participant
@meeDamian