Skip to content

Commit a5051fe

Browse files
fix!: Drop support for SQLAlchemy 1.4 (#1916)
1 parent b725f80 commit a5051fe

File tree

5 files changed

+5
-23
lines changed

5 files changed

+5
-23
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ env:
3737

3838
jobs:
3939
tests:
40-
name: "Test on ${{ matrix.python-version }} (${{ matrix.session }}) / ${{ matrix.os }} / SQLAlchemy: ${{ matrix.sqlalchemy }}"
40+
name: "Test on ${{ matrix.python-version }} (${{ matrix.session }}) / ${{ matrix.os }}"
4141
runs-on: ${{ matrix.os }}
4242
env:
4343
NOXSESSION: ${{ matrix.session }}
@@ -47,11 +47,9 @@ jobs:
4747
session: [tests]
4848
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
4949
python-version: ["3.8", "3.9", "3.10", "3.11"]
50-
sqlalchemy: ["2.*"]
5150
include:
52-
- { session: tests, python-version: "3.11", os: "ubuntu-latest", sqlalchemy: "1.*" }
53-
- { session: doctest, python-version: "3.10", os: "ubuntu-latest", sqlalchemy: "2.*" }
54-
- { session: mypy, python-version: "3.8", os: "ubuntu-latest", sqlalchemy: "2.*" }
51+
- { session: doctest, python-version: "3.10", os: "ubuntu-latest" }
52+
- { session: mypy, python-version: "3.8", os: "ubuntu-latest" }
5553

5654
steps:
5755
- name: Check out the repository
@@ -88,8 +86,6 @@ jobs:
8886
nox --version
8987
9088
- name: Run Nox
91-
env:
92-
SQLALCHEMY_VERSION: ${{ matrix.sqlalchemy }}
9389
run: |
9490
nox --python=${{ matrix.python-version }}
9591

noxfile.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,6 @@ def tests(session: Session) -> None:
8686
session.install(".[s3]")
8787
session.install(*test_dependencies)
8888

89-
sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")
90-
if sqlalchemy_version:
91-
# Bypass nox-poetry use of --constraint so we can install a version of
92-
# SQLAlchemy that doesn't match what's in poetry.lock.
93-
session.poetry.session.install( # type: ignore[attr-defined]
94-
f"sqlalchemy=={sqlalchemy_version}",
95-
)
96-
9789
try:
9890
session.run(
9991
"coverage",

poetry.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ memoization = ">=0.3.2,<0.5.0"
5050
jsonpath-ng = "^1.5.3"
5151
joblib = "^1.0.1"
5252
inflection = "^0.5.1"
53-
sqlalchemy = ">=1.4,<3.0"
53+
sqlalchemy = ">=2.0,<3.0"
5454
python-dotenv = ">=0.20,<0.22"
5555
typing-extensions = "^4.2.0"
5656
simplejson = "^3.17.6"

tests/conftest.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import typing as t
99

1010
import pytest
11-
from sqlalchemy import __version__ as sqlalchemy_version
1211

1312
from singer_sdk import SQLConnector
1413
from singer_sdk import typing as th
@@ -45,11 +44,6 @@ def pytest_runtest_setup(item):
4544
pytest.skip(f"cannot run on platform {system}")
4645

4746

48-
def pytest_report_header() -> list[str]:
49-
"""Return a list of strings to be displayed in the header of the report."""
50-
return [f"sqlalchemy: {sqlalchemy_version}"]
51-
52-
5347
@pytest.fixture(scope="class")
5448
def outdir() -> t.Generator[str, None, None]:
5549
"""Create a temporary directory for cookiecutters and target output."""

0 commit comments

Comments
 (0)