Skip to content

Commit aac5e45

Browse files
fix!: Drop support for SQLAlchemy 1.4 (#1916)
1 parent 2874a15 commit aac5e45

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ env:
3737

3838
jobs:
3939
tests:
40-
name: "Test on ${{ matrix.python-version }} (${{ matrix.session }}) / ${{ matrix.os }} / SQLAlchemy: ${{ matrix.sqlalchemy }}"
40+
name: "Test on ${{ matrix.python-version }} (${{ matrix.session }}) / ${{ matrix.os }}"
4141
runs-on: ${{ matrix.os }}
4242
continue-on-error: true
4343
env:
@@ -49,12 +49,11 @@ jobs:
4949
session: [tests]
5050
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
5151
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
52-
sqlalchemy: ["2"]
5352
include:
54-
- { session: tests, python-version: "3.12", os: "ubuntu-latest", sqlalchemy: "1" }
55-
- { session: doctest, python-version: "3.12", os: "ubuntu-latest", sqlalchemy: "2" }
56-
- { session: mypy, python-version: "3.12", os: "ubuntu-latest", sqlalchemy: "2" }
57-
- { session: deps, python-version: "3.12", os: "ubuntu-latest", sqlalchemy: "2" }
53+
- { session: tests, python-version: "3.12", os: "macos-latest" }
54+
- { session: doctest, python-version: "3.12", os: "ubuntu-latest" }
55+
- { session: mypy, python-version: "3.12", os: "ubuntu-latest" }
56+
- { session: deps, python-version: "3.12", os: "ubuntu-latest" }
5857

5958
steps:
6059
- uses: actions/checkout@v4
@@ -91,8 +90,6 @@ jobs:
9190
nox --version
9291
9392
- name: Run Nox
94-
env:
95-
SQLALCHEMY_VERSION: ${{ matrix.sqlalchemy }}
9693
run: |
9794
nox --verbose
9895

noxfile.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,6 @@ def tests(session: Session) -> None:
6464
session.install(".[faker,jwt,parquet,s3]")
6565
session.install(*test_dependencies)
6666

67-
sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")
68-
if sqlalchemy_version:
69-
# Bypass nox-poetry use of --constraint so we can install a version of
70-
# SQLAlchemy that doesn't match what's in poetry.lock.
71-
session.poetry.session.install( # type: ignore[attr-defined]
72-
f"sqlalchemy=={sqlalchemy_version}.*",
73-
)
74-
7567
env = {"COVERAGE_CORE": "sysmon"} if session.python == "3.12" else {}
7668

7769
try:

tests/conftest.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import typing as t
99

1010
import pytest
11-
import sqlalchemy as sa
1211

1312
from singer_sdk import SQLConnector
1413
from singer_sdk import typing as th
@@ -44,11 +43,6 @@ def pytest_runtest_setup(item):
4443
pytest.skip(f"cannot run on platform {system}")
4544

4645

47-
def pytest_report_header() -> list[str]:
48-
"""Return a list of strings to be displayed in the header of the report."""
49-
return [f"sqlalchemy: {sa.__version__}"]
50-
51-
5246
@pytest.fixture(autouse=True)
5347
def _reset_envvars(monkeypatch: pytest.MonkeyPatch):
5448
"""Remove envvars that might interfere with tests."""

0 commit comments

Comments
 (0)