-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Support message writing flags #2706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Bump. I think NaN as null would be a really nice feature or configuration setting. Especially since it's likely that most targets are going to be SQL-based databases or warehouses. Context: We're migrating from the I'm guessing we could use inline stream mappers to convert all these float fields to varchar for ingestion, but it's hundreds (possibly thousands?) of fields. Any other thoughts on workarounds? Thanks! |
That's interesting, I don't see any indication in the source of the pipelinewise connectors that would suggest they support NaN values. If we know the value causing problems, it may point to a more specific bug in the tap or targets. |
@edgarrmondragon It looks like pipelinewise's tap-postgres extractor converts NaN, Inf, and -Inf to None/null based on this code. |
I see. That kind of type conforming is actually fairly easy to patch here, so I'll open a PR. |
Reinstalling the MeltanoLabs/tap-postgres should get you the latest SDK patch, which handles those values. |
Feature scope
Taps (catalog, state, tests, etc.)
Description
When encoding/writing Singer messages to stdout, it'd be good to support certain flags that abstract the specifics of
json
,simplejson
,msgspec
, etc.Some flags could be:
TDB the specifics and how these interact with one another.
Related:
Nan
,Infinity
and-Infinity
to null values #2961The text was updated successfully, but these errors were encountered: