memfaultd 1.17.0 (Build 2808159)

Author: Memfault Inc

CHANGELOG.md

@@ -6,6 +6,46 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.17.0] - 2024-01-16
+This release introduces the new `memfaultctl write-metrics` command
+as well as some important bugfixes.
+
+### Added
+- `memfaultctl write-metrics`, which allows users to write
+metrics to `memfaultd` from a script or shell by specifying
+them as arguments to the command in the form `KEY=VALUE`.
+- 2 new built-in system metrics under the new `diskstats`
+metric category. These metrics follow the naming pattern
+`diskstats/<device name>/reads_per_second` and
+`diskstats/<device name>/writes_per_second` where 
+`<device name>` is the name of a device listed in
+`/proc/diskstats`. The list of devices monitored 
+can be configured with the `metrics.system_metric_collection.diskstats`
+configuration field.
+
+### Changed
+- The log message emitted when the MAR cleaner
+encounters an invalid MAR entry in the MAR 
+staging area has been lowered from `WARN` level
+to `DEBUG` level.
+- A log message emitted when the configured
+`high_resolution_telemetry.max_samples_per_minute`
+rate limit is violated has been lowered from `WARN`
+level to `DEBUG`. This is to avoid repeatedly 
+logging the same message at a high frequency 
+when the system is sending more readings than
+permitted. 
+
+### Fixed
+- All deltas calculated based on a current and previous
+counter from procfs now take potential overflow into account. 
+- Fixed a sequencing issue with the cleaning of the MAR directory 
+concerning an edge case where logs would fail to recover on 
+devices that are near their disk space or inode quotas. 
+This would result in stranded log files that would not 
+get deleted or uploaded to Memfault until there is enough 
+space to recover them.
+
 ## [1.16.1] - 2024-01-06
 
 This is a small release that adds coredump capture support for 32-bit ARM
@@ -1182,3 +1222,5 @@ package][nginx-pid-report] for a discussion on the topic.
   https://github.com/memfault/memfault-linux-sdk/releases/tag/1.16.0-kirkstone
 [1.16.1]:
   https://github.com/memfault/memfault-linux-sdk/releases/tag/1.16.1-kirkstone
+[1.17.0]:
+  https://github.com/memfault/memfault-linux-sdk/releases/tag/1.17.0-kirkstone

Cargo.lock

@@ -1,3 +1,3 @@
-BUILD ID: 2781235
-GIT COMMIT: ec62db9dc0
-VERSION: 1.16.1
+BUILD ID: 2808159
+GIT COMMIT: 9c4f0059da
+VERSION: 1.17.0

VERSION

@@ -1,6 +1,6 @@
 [package]
 name = "memfault-ssf"
-version = "1.16.1"
+version = "1.17.0"
 edition = "2021"
 description = "Supporting crate for the Memfault memfaultd embedded Linux agent"
 homepage = "https://github.com/memfault/memfaultd"

memfault-ssf/Cargo.toml

@@ -1,3 +1,3 @@
-BUILD ID: 2781235
-GIT COMMIT: ec62db9dc0
-VERSION: 1.16.1
+BUILD ID: 2808159
+GIT COMMIT: 9c4f0059da
+VERSION: 1.17.0

memfault-ssf/VERSION

@@ -1,6 +1,6 @@
 [package]
 name = "memfaultc-sys"
-version = "1.16.1"
+version = "1.17.0"
 edition = "2021"
 autobins = false
 description = "Supporting crate for the Memfault memfaultd embedded Linux agent"

memfaultc-sys/Cargo.toml

@@ -1,3 +1,3 @@
-BUILD ID: 2781235
-GIT COMMIT: ec62db9dc0
-VERSION: 1.16.1
+BUILD ID: 2808159
+GIT COMMIT: 9c4f0059da
+VERSION: 1.17.0

memfaultc-sys/VERSION

@@ -1,6 +1,6 @@
 [package]
 name = "memfaultd"
-version = "1.16.1"
+version = "1.17.0"
 edition = "2021"
 autobins = false
 rust-version = "1.72"
@@ -28,8 +28,8 @@ name= "mfw"
 path= "src/bin/mfw.rs"
 
 [dependencies]
-memfaultc-sys = { path= "../memfaultc-sys", version = "1.16.1" }
-ssf = { package = "memfault-ssf", path= "../memfault-ssf", version = "1.16.1" }
+memfaultc-sys = { path= "../memfaultc-sys", version = "1.17.0" }
+ssf = { package = "memfault-ssf", path= "../memfault-ssf", version = "1.17.0" }
 argh = "0.1.10"
 cfg-if = "1.0.0"
 chrono = { version = "0.4.23", features = ["serde"]}

memfaultd/Cargo.toml

@@ -1,3 +1,3 @@
-BUILD ID: 2781235
-GIT COMMIT: ec62db9dc0
-VERSION: 1.16.1
+BUILD ID: 2808159
+GIT COMMIT: 9c4f0059da
+VERSION: 1.17.0

memfaultd/VERSION

@@ -4,6 +4,7 @@
 use argh::{FromArgs, TopLevelCommand};
 use chrono::{DateTime, Utc};
 use std::{path::Path, str::FromStr, time::Duration};
+use write_metrics::write_metrics;
 
 mod add_battery_reading;
 mod config_file;
@@ -13,6 +14,7 @@ mod report_sync;
 mod session;
 mod sync;
 mod write_attributes;
+mod write_metrics;
 
 use crate::{
     cli::version::format_version,
@@ -108,6 +110,7 @@ enum MemfaultctlCommand {
     StartSession(StartSessionArgs),
     EndSession(EndSessionArgs),
     AddCustomDataRecording(AddCustomDataRecordingArgs),
+    WriteMetrics(WriteMetricsArgs),
 }
 
 #[derive(FromArgs)]
@@ -188,6 +191,15 @@ struct WriteAttributesArgs {
     attributes: Vec<DeviceAttribute>,
 }
 
+#[derive(FromArgs)]
+/// write metrics(s) to memfaultd
+#[argh(subcommand, name = "write-metrics")]
+struct WriteMetricsArgs {
+    /// metrics to write, in the format <VAR1=VAL1 ...>, or in statsd format <name:value|type ...>
+    #[argh(positional)]
+    metrics: Vec<KeyedMetricReading>,
+}
+
 #[derive(FromArgs)]
 /// add a reading to memfaultd's battery metrics in format "[status string]:[0.0-100.0]".
 #[argh(subcommand, name = "add-battery-reading")]
@@ -323,10 +335,11 @@ pub fn main() -> Result<()> {
                 ))
             } else {
                 check_data_collection_enabled(&config, "write attributes")?;
-                MarEntryBuilder::new(&mar_staging_path)?
-                    .set_metadata(Metadata::new_device_attributes(attributes))
-                    .save(&network_config)
-                    .map(|_entry| ())
+                let metrics = attributes
+                    .into_iter()
+                    .map(KeyedMetricReading::try_from)
+                    .collect::<Result<Vec<KeyedMetricReading>>>()?;
+                write_metrics(metrics, &config)
             }
         }
         MemfaultctlCommand::AddBatteryReading(AddBatteryReadingArgs { reading_string }) => {
@@ -379,5 +392,10 @@ pub fn main() -> Result<()> {
                 .save(&network_config)
                 .map(|_entry| ())
         }
+        MemfaultctlCommand::WriteMetrics(WriteMetricsArgs { metrics }) => {
+            check_data_collection_enabled(&config, "write metrics")?;
+
+            write_metrics(metrics, &config)
+        }
     }
 }